Consider migrating all the shiki-x projects into this monorepo about shiki HOT 23 CLOSED

That’s good timing. I just released @leafac/[email protected], which adds the ability to pass multiple highlighters. I’m doing this because I need to support dark mode, but it’s a generic enough implementation that I see it being useful if want to let the user pick a theme, for example.

In any case, the bottom line is: I’m using @leafac/rehype-shiki at work, I’m committed to maintaining it, I’m willing to bring it into the shikijs organization, and I’m already an administrator on the organization, so just say the word and I’ll make it happen.

from shiki.

@rsclarke Would you be interested in moving https://github.com/rsclarke/rehype-shiki to a repo here or as a package in the monorepo to continue maintaining it?

Apologies for the inactivity. It's been my intention to update the project/rewrite in TypeScript, I'm happy to bring it under the shikijs name, is there a preference for rehype-shiki as package in the monorepo or an independent repository?

from shiki.

@leafac Let's move forward with your fork then. Look forward to your PR.

from shiki.

Oops, sorry, I know it’s been a while. I’m on it!

from shiki.

No strong opinions on monorepo or not, whatever feels like the right fot

from shiki.

@leafac 👍 Made you admin

from shiki.

For rehype-shiki, do you want to transfer and continue to develop it under shikijs? I can make you admin for that project.

My branch of rehype-shiki is just a fork of @rsclarke 's repo. I only make it compatible with my branch of shiki. Maybe we can learn his idea.

from shiki.

The rehype-shiki project isn't up to date with the latest version of Shiki and @rsclarke hasn't been active on either Twitter or GitHub since this summer. Any chance we could fork it and move it into this project anyway?

from shiki.

• https://github.com/rsclarke/rehype-shiki
• https://github.com/leafac/shiki-latex
• https://github.com/EldoranDev/gridsome-plugin-remark-shiki
• https://github.com/microsoft/TypeScript-Website/tree/v2/packages/gatsby-remark-shiki-twoslash (I found it through https://fatihkalifa.com/typescript-twoslash, really beautiful rendering):
  

How would you go about this — just go asking them?
Also I'm wondering if we should keep some packages separate, for example shiki-latex, if we have an org it can be shikijs/shiki-latex.

from shiki.

Yah! That site is great!

Yeah, we just ask politely - it worked really well for the svelte tooling

from shiki.

Thanks for the mention on the new Shiki website!

I’m happy to transfer shiki-latex to the shikijs organization!

from shiki.

By the way, check out this video in which I talk about Shiki a whole lot (starting on 27:41).

from shiki.

@leafac Thanks a lot for your video tutorial!

I'm ok for transferring, but I haven't had a chance to play with shiki-latex yet and I wouldn't have time to fix bugs for it.

@orta Do we really have to keep everything in a monorepo or we can just keep the repos under the org?

from shiki.

I can continue maintaining the project.

from shiki.

@leafac Sent you an invitation for @shikijs. Feel free to transfer it to shikijs org. I'll grant you admin access.
Once I have some time I'll try to take a look of shiki-latex and see if there's anything I can help. Thanks again!

from shiki.

It’s transferred: https://github.com/shikijs/shiki-latex

from shiki.

@rsclarke Would you be interested in moving https://github.com/rsclarke/rehype-shiki to a repo here or as a package in the monorepo to continue maintaining it?

@Enter-tainer I see you made a lot of changes in your branch of shiki, and https://github.com/Enter-tainer/rehype-shiki. Would you be interested in working together to bring those changes upstream, and moving rehype-shiki to here or as a separate project under shikijs?

from shiki.

@rsclarke Would you be interested in moving rsclarke/rehype-shiki to a repo here or as a package in the monorepo to continue maintaining it?

@Enter-tainer I see you made a lot of changes in your branch of shiki, and Enter-tainer/rehype-shiki. Would you be interested in working together to bring those changes upstream, and moving rehype-shiki to here or as a separate project under shikijs?

I am happy to bring my changes upstream. I've added semantic highlighting and more code decorations (such as italic, underline, and bold fonts) to my branch of shiki.

• Semantic code highlighting is based on the language server protocol. It only works on nodejs. And it currently only supports C++. It works by communicating with clangd to get semantic tokens and then colorize them. However, the implementation may not be as cool as it sounds (dirty hacks) 😀. Moreover, this feature is breaking. In my branch of shiki, highlighter.codeToThemedTokens is a async function. As for this feature, I think more discussions are needed.
• As for code decorations, I am glad to bring them upstream.

from shiki.

Semantic code highlighting is based on the language server protocol

Nice! I didn't realize that you implemented this. Maybe we can take a look together in implementing #68.

highlighter.codeToThemedTokens is a async function

Yeah, this will make it hard to use it in markdown-it: markdown-it/markdown-it#40

more code decorations (such as italic, underline, and bold fonts)

Take a look at #23 (comment)
I'd say propose an API first before doing it. It's not that hard to implement it, but I care about having a good API.

For rehype-shiki, do you want to transfer and continue to develop it under shikijs? I can make you admin for that project.

from shiki.

@rsclarke Would you mind taking a look at rsclarke/rehype-shiki#49? Do you have enough time to maintain the library? If you are too busy, it seems @leafac and @Enter-tainer would be happy to lend a hand. No need to apologize, we all get busy sometimes.

I'll move on with the most actively maintained one for the shikijs org, though.

from shiki.

I’m just checking in to let y’all know that I’m still around and I’ll work on bringing everything (shiki-latex and @leafac/rehype-shiki) to the monorepo in the near future.

from shiki.

@leafac Any luck? Don't worry too much about making everything perfect before moving it into the org. You can still make changes as you use to do if you move it!

from shiki.

@leafac Feel free to transfer or leave it as-is. I'll link to it from docs either way.

from shiki.