dark_plus theme colors braces black about shiki HOT 5 CLOSED

@Enter-tainer Yeah, now I remember...VS Code has its default color, but those are not written in themes.
https://github.com/microsoft/vscode/blob/f7f05dee53fb33fe023db2e06e30a89d3094488f/src/vs/platform/theme/common/colorRegistry.ts#L176

I'll need to remember this, when I'm automating pulling themes from upstream.

from shiki.

Also facing this issue

from shiki.

It may result from wrong theme configuration. Since source code in dark mode should be white by default, I've add this rule to dark_vs.json. And then the braces becomes white.

		{
			"scope": "source",
			"settings": {
				"foreground": "#FFFFFF",
			}
		},

from shiki.

I'm sorry for writing in a closed issue but I'm seeing this with the github-dark and slack-theme-dark-mode theme as well. What can I do to help out fixing this?

• github-dark

  

• slack-theme-dark-mode

  

from shiki.

@vinkla See #100 which will be fixed in next ver.

from shiki.