shelljs cp handling symlinks badly about shelljs HOT 7 CLOSED

hey thanks for reporting this -- I've refactored the code, take a look at the source in src/cp.js. if you find the solution please bundle a test in test/cp.js too, thanks again!

from shelljs.

I think I am running into this issue as well.

from shelljs.

Hi @arturadib
How about the following condition ?

$ git diff src/cp.js
diff --git a/src/cp.js b/src/cp.js
index ef19f96..6a0abba 100644
--- a/src/cp.js
+++ b/src/cp.js
@@ -73,6 +73,14 @@ function cpdirSyncRecursive(sourceDir, destDir, opts) {
       cpdirSyncRecursive(srcFile, destFile, opts);
     } else if (srcFileStat.isSymbolicLink()) {
       var symlinkFull = fs.readlinkSync(srcFile);
+      if (fs.existsSync(destFile)) {
+          if (!opts.force) {
+            common.log('skipping existing file: ' + files[i]);
+            return;
+          } else {
+            fs.unlinkSync(destFile);
+          }
+      }
       fs.symlinkSync(symlinkFull, destFile, os.platform() === "win32" ? "junction" : null);
     } else {
       /* At this point, we've hit a file actually worth copying... so copy it on over. */

from shelljs.

@arturadib And.. one more question.
I'm looking for the way to copy the real files of symlink links, @eisnerd's PR(eisnerd@2e0ab9d) looks a solution about this.. So, I'm curious if this PR can be applied to the master.

from shelljs.

No PR has been opened including eisnerd@2e0ab9d, but one could be opened for master, i.e., including the commit with the test. I'm not sure this relates to #69. I may have misunderstood #69 as relating to creation of dangling symlinks, which fails in windows, from what I remember.

from shelljs.

@arturadib , @eisnerd :
I just made a PR (#164), referred to eisnerd@2e0ab9d and added some condition to delete the existing files for -f option.

from shelljs.

I think the original issue has since been fixed. I'm going to close this, but I'll open another issue that discusses some of the other issues surrounding symlinks.

from shelljs.