The logic is faulty when the system snaps new cellsizes to multiples of the current ce

The relevant code is at <div class="Box-he

GUI: unable to change basedata cellsize when origin is non-zero about biodiverse HOT 1 CLOSED

shawnlaffan commented on July 18, 2024

GUI: unable to change basedata cellsize when origin is non-zero

from biodiverse.

Comments (1)

shawnlaffan commented on July 18, 2024

The relevant code is at

biodiverse/lib/Biodiverse/GUI/Manager/BaseDatas.pm

Lines 775 to 797 in ddc901f

    
               foreach my $widget (@resolution_widgets) { 
        
                   $j++; 
        
                   $widget->signal_connect ( 
        
                       'value-changed' => sub { 
        
                           my $val = $widget->get_value; 
        
                           #  Avoid fmod - it causes grief with 0.2 cell sizes 
        
                           #  prob due to floating point issues. 
        
                           #  Precision should be configurable... 
        
                           my $offset = ($val - $origins_array[$j]) 
        
                                       / $cellsize_array[$j]; 
        
                           if ($cellsize_array[$j] < 1) { 
        
                               $offset = ($offset * 10e10 + 0.5) / 10e10; 
        
                           } 
        
                           $offset -= int $offset; 
        
                           #  effectively zero given cell size constraints 
        
                           if ($offset > 10e-10) { 
        
                               $val -= $offset; 
        
                               $widget->set_value ($val); 
        
                           } 
        
                           return; 
        
                       } 
        
                   ); 
        
               }

It can be simplified to this:

    foreach my $widget (@resolution_widgets) {
        $j++;
        $widget->signal_connect (
            'value-changed' => sub {
                my $val = $widget->get_value;
                my $remainder = fmod ($val, $cellsize_array[$j]);
                if (abs ($remainder) > 10e-10) {
                    $widget->set_value ($val - $remainder);
                }
                return;
            }
        );
    }

from biodiverse.

GUI: unable to change basedata cellsize when origin is non-zero about biodiverse HOT 1 CLOSED

Comments (1)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	foreach my $widget (@resolution_widgets) {
	$j++;
	$widget->signal_connect (
	'value-changed' => sub {
	my $val = $widget->get_value;
	# Avoid fmod - it causes grief with 0.2 cell sizes
	# prob due to floating point issues.
	# Precision should be configurable...
	my $offset = ($val - $origins_array[$j])
	/ $cellsize_array[$j];
	if ($cellsize_array[$j] < 1) {
	$offset = ($offset * 10e10 + 0.5) / 10e10;
	}
	$offset -= int $offset;
	# effectively zero given cell size constraints
	if ($offset > 10e-10) {
	$val -= $offset;
	$widget->set_value ($val);
	}
	return;
	}
	);
	}