DataStream should be split up about sharpdx HOT 5 CLOSED

Can you please provide more details about this idea? (or a code sample, if possible)
Currently DataStream class has ~230 usages only in SharpDX.sln, so any changes to it should be implemented with extreme caution.

from sharpdx.

DataStream is a legacy class inherited from SlimDX and mainly used for backward "compatibility", as artiom noted, It is quite heavily referenced. If you want to have random access to a memory buffer you could use DataBuffer. Also, Utilities.Read/Write are often a simpler alternative. It is usually better to avoid using DataStream.

from sharpdx.

An example can help here to explain what I mean:

The font collection loader interface method CreateEnumeratorFromKey
http://msdn.microsoft.com/en-us/library/windows/desktop/dd368216(v=vs.85).aspx

takes in a pointer to the key and size of the key.

The SharpDX version of this method
http://sharpdx.org/documentation/api/m-sharpdx-directwrite-fontcollectionloader-createenumeratorfromkey

uses a DataStream to represent this key

IMHO a DataStream should not be used to refer to pieces of memory like this key argument,

The same can be said for FontFileLoader.CreateStreamFromKey and maybe other methods too.

I guess a SharpDX.DataPointer would be more suitable to marshalling the concept of a "block of memory".

from sharpdx.

Sure, DataPointer was introduced in SharpDX to avoid making DataStream mandatory (DataBuffer and DataStream are automatically castable to DataPointer), so yes, for these methods, I think that's better to make them use DataPointer.

from sharpdx.

Some of the DataStream usages were replaced by DataPointer (in the SharpDX.Direct2D1 assembly).
Feel free to post here if there are some specific usages that need to be refactored.

from sharpdx.