Add windows compatibility about fd HOT 13 CLOSED

Thank you for trying this. I'll try to implement this as soon as I get access to a Windows system.

from fd.

I'd be happy to create a pull request!

from fd.

That would be great, thank you.

from fd.

Apart from the current compilation problems, colored output does not work on Windows (no support for ANSI sequences). We could consider using termcolor.

from fd.

PR #35 concerns windows compatibility.
Powershell does work with colored output. To be honest I haven't touched cmd since the inception of Powershell, but the termcolor crate looks like a nice feature for the hardcore cmd users!

from fd.

Oh, I didn't know that, that's cool! I just quickly tried cmd today.. thanks!

from fd.

Closed via #35

from fd.

I'm surprised this was closed considering colored output does not work in cmd.exe, I'm getting ansi escapes printed to the console every time I fire up fd and have to add the --no-color option each time. Maybe we should re-open this/add an issue on Windows coloring? termcolor crate sounded like a great option.

from fd.

This issue was regarding compatibility; The code simply didn't compile on windows. Having to flag no-color should be the default behavior imho since this is a shortcoming of cmd, not Windows. If you want colored output, try Powershell. It's like bash and Python had a baby in Microsoft country. (And it's developed by MSFT)

from fd.

from fd.

Then by all means, start a pull request to add cmd support. I'm just saying that cmd support is not the same as windows compatibility, and should be opened as another issue.

from fd.

I looked into it a bit today, there's a few issues in order to implement it:

• cmd has no support for "italic" or "underlined" text, in which case these options should be ignored
• after checking out termcolor, I see no support for fixed colors. There seems to be work in progress here

from fd.

@jmcomets Cool, thanks for looking into this! I also think we should open a new issue for this.

from fd.