[BUG] Including hidden files also includes (git)ignored files if the .gitignore is in the parent directory about fd HOT 4 OPEN

Sorry for not responding earlier; I wanted to dig a little bit into it and hadn't had the time to do that before.

The problems might be similar, but I don't think they are directly related. I think I tracked down the problem for the hidden files in the ignore crate, and made a PR there (BurntlSushi/ripgrep#2711).

In the meantime, until it gets fixed in ripgrep, one could apply the fix I proposed above?

from fd.

This definitely seems like a bug in the ignore crate. You should have a .git folder in your reproducer, but even with that it fails:

tavianator@graphene $ tree -a .
.
├── .abc
├── .git
├── .gitignore
└── sub_directory
    └── .abc

2 directories, 4 files
tavianator@graphene $ cat .gitignore
.abc
tavianator@graphene $ cd sub_directory
tavianator@graphene $ fd --hidden
.abc
tavianator@graphene $ fd --hidden --search-path ./
tavianator@graphene $ rg --hidden --files .
./.abc
tavianator@graphene $ rg --hidden --files ./
tavianator@graphene $ 

Since rg by itself can reproduce the bug, it should be reported to https://github.com/BurntSushi/ripgrep (unless there's already a duplicate, but I didn't find one quickly).

from fd.

This seems somewhat similar to BurntSushi/ripgrep#829.

from fd.

That seems reasonable as long as it doesn't break anything else

from fd.