Core.JavaScript: Util.ts - other external dependencies about pnp-js-core HOT 3 CLOSED

hi patrick,
regarding underscore, i think that the tendency of the community has moved towards lodash over underscore and i believe that there are performance reasons for this as well.

another thing to consider here is that lodash makes individual modules available on npm. so we can cherry pick only the necessary modules if size really is an issue. Personally, I don't see 5kb as too big

from pnp-js-core.

The less external library dependencies we have:

• the easier it will be to use and not cause potential runtime conflicts (thinking site owner scenarios who are coding JavaScript in Script Editor/Content Editor Web Parts and many others).
• the more flexible it will be to let users choose whatever external library (and version of the library) they want for those kind of things

That said, of course we need those kinds of util functions internally as well.

So it's a balance of:

Do we expose these util functions as a public api? or we just keep it internal only and let other internal code use it as needed?

Don't think it's easy to answer that one. More a judgement call than anything.

from pnp-js-core.

Going to close this one - I think great points and we will aim to limit the number dependencies. This is why we have created our own utils library to not take a dependency for a few lines of code. Thanks for the input guys!

from pnp-js-core.