Code Monkey home page Code Monkey logo

Comments (8)

vidyap-xgboost avatar vidyap-xgboost commented on May 18, 2024 1

I see there is a issue in readme.
We need to printmodels variable to see the results. Try the same example again and just type models you will see the results.

That would work. Without print(), it sent the wrong message to me. Thanks for being patient and answering all questions. 👍

from lazypredict.

vidyap-xgboost avatar vidyap-xgboost commented on May 18, 2024 1

Happy to work on this library. I appreciate you starting this library as it is easier for prototyping before implementing complex models in Machine Learning. 👍

from lazypredict.

vidyap-xgboost avatar vidyap-xgboost commented on May 18, 2024

[UPDATE]

>>>import lazypredict

works only after following these steps on my environment (Ubuntu 18.04, python==3.6.9):

$ git clone git@github.com:your_name_here/lazypredict.git
$ mkvirtualenv lazypredict
$ cd lazypredict/
$ python setup.py develop
$ pip3 install -r requirements_dev.txt

I added $ pip3 install -r requirements_dev.txt because when I ran the example given in the docs, it asked me to install numpy. That should have been automatically installed when I ran setup.py, however, requirements.txt instruction was not given in CONTRIBUTING.md. Once I did that, everything ran smoothly.

from lazypredict.

vidyap-xgboost avatar vidyap-xgboost commented on May 18, 2024

[DOCUMENTATION]

In any example, for now let's take Classification, the examples are written as if they're executed using a .py file. That's how I assumed because an interactive shell would include >>> in them. When I ran the .py file, it executed the program well, however, I did not see any output. Why? Because the original example, I am assuming here again, was run on an interactive python shell. That's when I could immediately see the results as shown in the docs.

To see the output, the author should either explicitly mention that the examples should be run on an interactive shell or change the examples to accommodate the traditional >>> 3 arrows to indicate that those examples are running on an interactive shell.

Let me know if I am wrong anywhere. Happy to discuss.

from lazypredict.

shankarpandala avatar shankarpandala commented on May 18, 2024

@vidyap-xgboost This is interesting. No one faced this this issue.
can you create a new conda environment and try installing with pip instead of pip3 ?

Regarding numpy and other packages not getting installed with pip. I think that is how pip works. while conda install will check for every dependency and install them. As this library is not published in conda yet we cannot use conda.

But, let me check the possibility of installing dependencies while installing with pip

Regarding installation instructions, They are available in the docs. You can see it here : https://lazypredict.readthedocs.io/en/latest/installation.html

I think cloning the repo and installing the requirements is not a good idea here as this is not a project but a library.

You are always open to raise a PR.

from lazypredict.

vidyap-xgboost avatar vidyap-xgboost commented on May 18, 2024

@vidyap-xgboost This is interesting. No one faced this this issue.
can you create a new conda environment and try installing with pip instead of pip3 ?

I will look into this.

Regarding numpy and other packages not getting installed with pip. I think that is how pip works. while conda install will check for every dependency and install them. As this library is not published in conda yet we cannot use conda.

But, let me check the possibility of installing dependencies while installing with pip

Sure, thanks for the clarification.

Regarding installation instructions, They are available in the docs. You can see it here : https://lazypredict.readthedocs.io/en/latest/installation.html

I think cloning the repo and installing the requirements is not a good idea here as this is not a project but a library.

You are always open to raise a PR.

I agree. I added the installation instruction directly on README assuming people would be looking for it. A direct link to the docs is already provided but beginners wouldn't know where to look for unless Installation is explicitly mentioned right in the GitHub README (if they come across this first).

Could you also answer this question as well?

[DOCUMENTATION]

In any example, for now let's take Classification, the examples are written as if they're executed using a .py file. That's how I assumed because an interactive shell would include >>> in them. When I ran the .py file, it executed the program well, however, I did not see any output. Why? Because the original example, I am assuming here again, was run on an interactive python shell. That's when I could immediately see the results as shown in the docs.

To see the output, the author should either explicitly mention that the examples should be run on an interactive shell or change the examples to accommodate the traditional >>> 3 arrows to indicate that those examples are running on an interactive shell.

Let me know if I am wrong anywhere. Happy to discuss.

Finally, thanks for the merge!

from lazypredict.

shankarpandala avatar shankarpandala commented on May 18, 2024

I see there is a issue in readme.
We need to printmodels variable to see the results. Try the same example again and just type models you will see the results.

from lazypredict.

shankarpandala avatar shankarpandala commented on May 18, 2024

Yeah it's a bug in the documentation that needs to be fixed. I appreciate your time in raising all the issues this will improve the library. Thanks.

from lazypredict.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.