Code Monkey home page Code Monkey logo

Comments (3)

shama avatar shama commented on August 16, 2024

There is a non-standard API Promise.denodeify to help convert Node.js compatible callbacks to promises but that API signature in your example doesn't match the Node.js standard of error first in callbacks.

But you can just wrap it in a promise to turn it into a promise:

const Market = require('some-api');
const promise = new Promise((resolve, reject) => {
  const myMarket = new Market();
  myMarket.websockets.trades(request[1], (trades, error) => {
    if (error) {
      reject(error);
      return;
    }
    if (this.streamStatus === 1) {
      resolve(JSON.stringify(['TR', this.getTimeString(), trades]));
    } else {
      reject(new Error('This promise wasnt handled'));
    }
  });
});

promise
  .then((json) => { /* do stuff with json */ })
  .catch((err) => { /* do stuff with err */ })

from letswritecode.

allawitte avatar allawitte commented on August 16, 2024

from letswritecode.

shama avatar shama commented on August 16, 2024

Ah ha, I see. If (trades, error) => {} gets called multiple times then it's effectively an Event Emitter. In which case you shouldn't use a promise here. Promises are intended to be resolved a single time so they're not a very good API for events.

from letswritecode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.