Question: Does Non-Server-Rendering Need "therubyracer" and "execjs"? about react_on_rails HOT 9 CLOSED

The gemspec includes:

  s.add_dependency "execjs", "~> 2.5"

So the gem depends on execjs, not therubyracer.

So yes, it's really not good to put in the gemfile.

We should add it as commented out and mention that you should set this if you plan to do server rendering.

Good catch.

We should have a file in the /docs directory on server rendering topics, BTW.

from react_on_rails.

@robwise Can we close this issue? I see this as a doc only issue.

from react_on_rails.

@justin808 It's up to you, I think I created this one a while back at your request. Right now the docs still say to manually include the therubyracer gem along with the react_on_rails gem in the Gemfile, and I'm still have the generator results script do that as well. If we want to remove that step, we should probably do some thorough testing and try to understand why it was put there in the first place.

from react_on_rails.

I'd say check react-rails.

We have a peer dependency of execjs already in the gem.

I'm almost 100% sure that we should not be putting in the therubyracer for non pre-render generators (and doc'd as such).

from react_on_rails.

@justin808 roger that, I will look into it and take it out if possible

from react_on_rails.

@justin808 while we're talking gem dependencies, we really should have foreman in there instead of just assuming people are going to have it.

from react_on_rails.

Probably. Maybe a non-production dependency. There's differing thoughts on including foreman in the gemfile.

from react_on_rails.

@robwise can we close this one?

from react_on_rails.

Yes, fixed in c21012a from PR #108

from react_on_rails.