Code Monkey home page Code Monkey logo

Comments (5)

joeyparrish avatar joeyparrish commented on June 12, 2024

This may require an update to the embedded version of Shaka Player. We have built-in CC parsing now, whereas earlier versions of Shaka Player required an additional library called mux.js for CC parsing.

from shaka-player-embedded.

Rastrelli1 avatar Rastrelli1 commented on June 12, 2024

Yes, I see patch with replace muxjs to CC608 decoding on v3.0 of shaka player, but decided to copy shaka-player/node_modules/mux.js/dist/mux.js (v2.5.14) into framework, and loaded after player
  JsManagerImpl* manager = JsManagerImpl::Instance();   CHECK(RunScript(manager->GetPathForStaticFile("shaka-player.compiled.js")));   CHECK(RunScript(manager->GetPathForStaticFile("mux.js")));

and this work, showed CC as expected. Thanks, I will closed this issue)

from shaka-player-embedded.

joeyparrish avatar joeyparrish commented on June 12, 2024

Thank you for the update, but I would like to reopen it until we have updated the embedded build of Shaka Player.

from shaka-player-embedded.

Rastrelli1 avatar Rastrelli1 commented on June 12, 2024

Thanks, if this needed of course let's update player
We have the same problem with TTML subtitles in #225, @joeyparrish can you answer on description questions, where we need integrate showing subtitles with images, on shaka layer, or on embedded wrapper?

from shaka-player-embedded.

joeyparrish avatar joeyparrish commented on June 12, 2024

In Shaka Player on the web, image-based subtitles are displayed through the DOM, which is driven by a TextDisplayer plugin (UITextDisplayer). In Embedded, I believe there would have to be a TextDisplayer plugin that is implemented in C++ to pipe the data up to where it can be displayed. Nobody at Google has had time to work on that.

from shaka-player-embedded.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.