Code Monkey home page Code Monkey logo

Comments (3)

robgjansen avatar robgjansen commented on May 20, 2024

I was thinking all events in shadow would follow the same pattern instead of having event "subtypes". This means the non-vci events (DTIMER, SIMOP, TICKTOCK) would also be refactored to extend the abstract class.

Or would it be better to differentiate "virtual" communication events (i.e. one node creating an event for itself or for another) from "physical" communication events (i.e. one process or thread creates events for another process or thread)?
Thoughts?

from shadow.

jdgeddes avatar jdgeddes commented on May 20, 2024

It seems that it is definitely possible to have just one abstract event class which is used both for virtual and physics events. However, there would seem to be quite a few variables that would just be used by the VCI events, and I would think having two separate abstract classes would allow for easier expansion for events that needed to be added to either the physical or virtual event class, especially if they differed in some major way.

For now I'll just go ahead and create a separate abstract class for non-vci events, but if at any point it's decided that it's better to have just one abstract class, it should be a relatively easy to make that change.

from shadow.

robgjansen avatar robgjansen commented on May 20, 2024

Any part of this that may not have been done will be cleaned up during the re-write of the threading engine.

from shadow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.