Comments (3)
dgmstuart
commented on July 26, 2024
@dsandstrom I guess we can treat this one of two ways:
- Treat it as a breaking change and decide that we need a separate branch for Rails 5
- Decide it doesn't matter much and do a fuzzy match:
expect(node).to have_css('input[type^="datetime"]')(matches inputs with types beginning with "datetime")
I'll submit a PR for the latter
from foundation_rails_helper.
dsandstrom
commented on July 26, 2024
I went with option 1 for the foundation-6 branch. I never commited the same fix to master, thinking we would stop development on master and focus on foundation-6 only. Using the fuzzy search is probably better anyhow.
from foundation_rails_helper.
dgmstuart
commented on July 26, 2024
Cool - if you think it's OK, would you mind merging?
from foundation_rails_helper.
Related Issues (20)
- Add ability to add prefix and postfix HOT 8
- Radio Button Helper Renders Value in Label HOT 2
- Needs a version bump. HOT 14
- Migrate TravisCI to container-based infrastructure HOT 1
- Remove Ruby 1.9.3 from supported Rubies HOT 13
- Support for Foundation 6 HOT 4
- fggh HOT 2
- Support rails 5 HOT 1
- alias_method_chain is deprecated HOT 6
- Release a new gem version for Rails 5 support HOT 2
- Foundation 6 - Form input "hint" is now "help text" HOT 1
- Foundation 6 - Change default button class HOT 2
- Release 3.0.0 HOT 7
- Make error_for method in form_builder public HOT 1
- Overriding the field_error_proc HOT 2
- display_flash_messages return nil on redirection HOT 4
- Newest changes that include update to support rails 6 in gemspec not in rubygem.org HOT 2
- Can we release a new version of the gem so we can upgrade our rails to >= 6.1 HOT 1
- Publish v4.0.0 code on GitHub HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from foundation_rails_helper.