Update the "All about inserts" guide to diesel 2.0 about diesel.rs-website HOT 5 CLOSED

I have some questions, as I've noticed some inconsistencies in the original pages ("All About Inserts" & "All About Updates"), and I'd like to make them consistent while I update them:

• In the SQL code blocks, should I be using $1 etc. or ? ?
• Should I include or exclude the --binds ["foo"] SQL comments?

from diesel.rs-website.

First of all: Thanks for working on this. Your PR's are really helpful.

To answer your two questions:

In the SQL code blocks, should I be using $1 etc. or ? ?

I would use $1 etc. there as this is the postgres specific bind syntax and all of the guides currently assume that you use postgres.

Should I include or exclude the --binds ["foo"] SQL comments?

I would include the binds there, as this is the output generated by debug_query. Additionally that gives an hint which values where used in place of the bind.

I'm only able to perform a complete review of your PR's next week, as I'm away from my PC for this weekend.

from diesel.rs-website.

Okay, sounds great. I ended up busier this weekend than I expected, but I will have time this week to finish up.

from diesel.rs-website.

No worries, take your time. Your contributions are already really helpful.

from diesel.rs-website.

Fixed by #160

from diesel.rs-website.