Comments (2)
This is probably the single most frequently raised issue among users of this library, and not without good reason. It turns out my own unit tests contained an erroneous usage of operator *
when matrix multiplication was intended. Through some quirk of fate, the specific version of doctest
I was using wasn't correctly invoking templated test cases, and the broken test slipped through.
I've decided to deprecate operator *
between pairs of matrices, and provide an unambiguous cmul(...)
function that can be called by users who actually want the component-wise (Hadamard) product between matrices. operator *
will remain supported for all other patterns with its original semantics.
It took a little bespoke machinery to do so, but I was able to split the definition of operator *
into two overloads, one for matrix * matrix
, and one for everything else, and attached a deprecation attribute to the matrix * matrix
overload, so it should raise a warning any time it is used.
Furthermore, if you #define LINALG_FORWARD_COMPATIBLE
, either before including linalg.h
or globally across your project, it will remove the matrix * matrix
overload completely, making that construct a hard compiler error.
Take care, and happy coding!
from linalg.
This is excellent! Huge thanks for this, it helps us a lot!
from linalg.
Related Issues (20)
- Reduction functions for matrices? HOT 2
- Identity() HOT 3
- User Code Extensions HOT 3
- Undefined behavior on operator[] overload prevents use in constexpr context HOT 3
- Fix semantics of operator overloads on matrices. HOT 4
- Finish documentation for `v3` branch. HOT 1
- Impossible to create row vectors HOT 5
- Question about column order. HOT 1
- Doesn't build on MSVC 2017 HOT 3
- Future usability wishlist HOT 4
- `mul()` gives wrong answer? HOT 1
- Initializing a std::array of vecs HOT 3
- glm::lookAt equivalent? HOT 10
- `using namespace linalg::ostream_overloads` sometimes does not work. HOT 1
- Suggestion: projection_onto() and rejection_from() functions for vectors HOT 1
- mul(a,b,c) with visual studio 2017 release candidate HOT 5
- Compilation with clang fails on OS X (error: ambiguous call to std::abs()) HOT 1
- rotation_quat fails in some cases HOT 8
- avoid GCC -Wshadow warnings? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from linalg.