Comments (23)
Very cool, I think we can merge now?
from sgnl05-sssd.
Yes, that would be nice. I'll look into it, unless you have nice recipe.. ;)
from sgnl05-sssd.
This commit from another module looks interesting: kindredgroup/puppet-forge_server@096b1d3
Not sure tho how Forge username and password is hashed.
from sgnl05-sssd.
Yea I saw it in a unibet module as well: https://github.com/unibet/puppet-vagrant
You probably set up the key on the travis site with environment vars etc...
However, puppetforge is not listed here: https://docs.travis-ci.com/user/deployment/
I've seen this before. I suspect it is the underlying mechanism that travis uses.
https://github.com/travis-ci/dpl#puppet-forge
I wonder if puppetforge just hasn't made it to the documentation yet.
from sgnl05-sssd.
We can probably just follow along with one of the other providers that uses a username/pass...
https://docs.travis-ci.com/user/deployment/appfog
Encrypting the pass is done with the travis tool, available as a gem:
https://blog.travis-ci.com/2013-01-14-new-client/
from sgnl05-sssd.
I've made a branch named autodeploy with the changes I think is necessary (based on https://github.com/voxpupuli/puppet-zabbix/blob/master/.travis.yml). If it looks right to you, can you please merge it and test a deploy next time we have something to release?
from sgnl05-sssd.
What does this option do?
https://github.com/voxpupuli/puppet-zabbix/blob/master/.travis.yml#L42
That is the only thing that does not make sense to me...
from sgnl05-sssd.
Its a branch here for travis deploy:
https://github.com/travis-ci/dpl/commits/ha-bug-puppet-forge
But it looks like that has been merged into master and tagged for release already, so we probably do not need it any longer.
from sgnl05-sssd.
I have concerns about the matrix.
I'm honestly still trying to understand the new matrix format.
I think this is in an include:
https://github.com/voxpupuli/puppet-zabbix/blob/master/.travis.yml#L29
However ours is in an exclude.
Our travis matrix is now different in format that puppet-zabbix, from the last merge.
from sgnl05-sssd.
@edestecd The new matrix tests every supported version combination of ruby and puppet and the excludes are for none incompatibilities. This method actually tests all the platforms that we say are supported as opposed the zabbix example that tests only a few cases.
from sgnl05-sssd.
@ghoneycutt yup it seems more complete to me. I wasn't trying to imply it was better or worse, just that we can't exactly copy the zabbix example for auto deploy, since that matrix is different. Do you know of an auto deploy (to the forge) example that uses this matrix format? That would be most helpful ;)
from sgnl05-sssd.
Perhaps just moving this:
https://github.com/sgnl05/sgnl05-sssd/pull/28/files#diff-354f30a63fb0907d4ad57269548329e3R72
To the above matrix:
Line 10 in 3317f19
Would do the trick. But it seems like this may run more than once on each ruby, so we probably still need to exclude ruby 1.9.3 and 2.1.0 in the exclude.
from sgnl05-sssd.
I updated .travis.yml with what you suggested @edestecd
I also did a search for any .travis.yml file on github that uses matrix exclude and puppetlabs as provider for deploy. Among many, these two came up:
https://github.com/hercules-team/augeasproviders_sysctl/blob/master/.travis.yml
https://github.com/maestrodev/puppet-perforce/blob/master/.travis.yml
If both examples above work, then I believe ours will work too.
from sgnl05-sssd.
It tried to deploy multiple times, but I think I got it right this time after adding some excludes.
from sgnl05-sssd.
I like this:
https://github.com/hercules-team/augeasproviders_sysctl/blob/master/.travis.yml#L95
Doing the two excludes is effectively the same, but more verbose...
from sgnl05-sssd.
I tried adding "rvm: 1.9.3" through 4d800d1, but it had no effect..
from sgnl05-sssd.
Hmm, maybe they are doing something else then...
As long as it works ;) Thanks for the effort. I'll be doing this to my other modules soon and now I have a great example!
from sgnl05-sssd.
Ah, I figured out the "rvm:"-thing. I expected it to work the same way as an exclude would. If you look at https://travis-ci.org/hercules-team/augeasproviders_sysctl/builds/171974370, you'll see build jobs with "FORGE_PUBLISH=true" for all Ruby versions. However, deploy is only triggered on the job with version 1.9.3. The other two get this message: "Skipping a deployment with the puppetforge provider because this is not on the required runtime".
from sgnl05-sssd.
So using exclude gives us less useless build jobs. ;)
from sgnl05-sssd.
OK I see, it does the build, but bails. I agree, that seems less useful.
from sgnl05-sssd.
Did this work for the last release? Can we close this issue?
from sgnl05-sssd.
We implemented this after the last release. So we'll have to test it on the upcoming release.
from sgnl05-sssd.
Worked! https://travis-ci.org/sgnl05/sgnl05-sssd/jobs/194817099
from sgnl05-sssd.
Related Issues (20)
- Looking for new project owner HOT 13
- Mkhomedir issue on CentOS 8 HOT 2
- Smart Parameter for config - Error with Hash value HOT 1
- please update puppetlabs/stdlib dependency to < 7.0.0 HOT 2
- Order of sssd.conf and authconfig-mkhomedir
- How to get this to work with Centos8 HOT 3
- Cannot install sgnl05-sssd with current puppetlabs-stdlib HOT 2
- Questions about development against this module HOT 2
- Version 3.1.0 broken for Oracle Linux 8 HOT 1
- PE 2021 and Puppet 7 support missing HOT 1
- Fix legacy fact HOT 3
- Add support for stdlib 7.x+
- Package[libpam-runtime] is already declared
- Package sssd-32bit is not available on 32 bit Suse HOT 7
- Drop support for Puppet 4
- Drop support for unsupported platforms
- Support for Fedora 29 HOT 2
- support for ad access_provider HOT 1
- Version check in init.pp is incorrect HOT 1
- cache_credentials always true HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sgnl05-sssd.