Comments (25)
FabioLolix
commented on May 19, 2024
1
The fix works
from openage.
FabioLolix
commented on May 19, 2024
1
Yes, 4 cmake build type build and run
from openage.
heinezen
commented on May 19, 2024
1
Great, the release is live 💯
from openage.
heinezen
commented on May 19, 2024
Can you check in the debugger which line this happens on, please?
from openage.
FabioLolix
commented on May 19, 2024
I have installed gdb but I don't know how to use it
from openage.
FabioLolix
commented on May 19, 2024
this is the last coredump core.python3.1000.2b4b1c40ab1148bd94c5facb9e4ff62c.129239.1696798076000000.tar.gz
from openage.
heinezen
commented on May 19, 2024
Can you post the modpack.toml file in hd_base, please? That might have something to do with the error.
from openage.
FabioLolix
commented on May 19, 2024
Here
# openage modpack definition file
file_version = "2"
[info]
name = "hd_base"
version = "0.5"
versionstr = "5.8"
repo = "openage"
[assets]
include = [ "data/**",]
exclude = []
[dependency]
modpacks = []
[conflict]
modpacks = []
[authors]
[authorgroups]
from openage.
heinezen
commented on May 19, 2024
hd_base looks OK. Can you also send me the modpack.toml of the engine modpack? I'm pretty sure the error comes from there.
from openage.
yangzhangstl
commented on May 19, 2024
same problem
from openage.
FabioLolix
commented on May 19, 2024
Here, this says version = "0.4.0"
# openage modpack definition file
file_version = "2"
[info]
name = "engine"
version = "0.4.0"
repo = "openage"
[assets]
include = [ "**",]
exclude = []
[dependency]
modpacks = []
[conflict]
modpacks = []
[authors]
[authorgroups]
from openage.
heinezen
commented on May 19, 2024
@FabioLolix Looks okay... can you chek if #1574 helps? I still can't repoduce this locally.
from openage.
FabioLolix
commented on May 19, 2024
patched GCC build but have the same errors
$ openage game --modpacks hd_base
INFO [py] launching openage v0.4.1-1532-g4773e70ff
INFO [py] compiled by GNU 13.2.1
INFO [py] openage nyan API modpack is up to date
INFO [py] Found modpack engine
INFO [py] Found modpack hd_base
INFO loading configuration files...
INFO [py] loading config file [Union(<openage.util.fslike.union.Union object at 0x7eff2e8ac090>.root @ (b'cfg',), <openage.util.fslike.union.Union object at 0x7eff2e89c150>.root @ (b'assets',))]:cfg/keybinds.oac...
INFO launching engine with root directoryPath(Union(<openage.util.fslike.union.Union object at 0x7eff2e8ac090>.root @ (b'cfg',), <openage.util.fslike.union.Union object at 0x7eff2e89c150>.root @ (b'assets',)):)
INFO loading configuration files...
INFO [py] loading config file [Union(<openage.util.fslike.union.Union object at 0x7eff2e8ac090>.root @ (b'cfg',), <openage.util.fslike.union.Union object at 0x7eff2e89c150>.root @ (b'assets',))]:cfg/keybinds.oac...
INFO Found modpack: engine
INFO Found modpack: hd_base
INFO Created game simulation
INFO Activated modpack: engine
INFO Activated modpack: hd_base
INFO Created 3 threads (24 available)
INFO [T1] Presenter: Launching subsystems...
INFO [T1] Presenter: Initializing graphics subsystems...
INFO [T2] Time loop started
FATAL: terminate has been called
uncaught exception
std::exception of type std::bad_alloc: std::bad_alloc
current stack:
Traceback (most recent call last):
File ?, in ? [0x7eff31eaa9eb]
File ?, in ? [0x7eff30ae1943]
File ?, in ? [0x7eff2e483ae9]
File ?, in openage::gamestate::GameSimulation::run()+0x2f [0x7eff2e4ee8cf]
File ?, in openage::gamestate::GameSimulation::start()+0xaf [0x7eff2e4ee6ff]
File ?, in openage::gamestate::Game::Game(std::shared_ptr<openage::event::EventLoop> const&, std::shared_ptr<openage::assets::ModManager> const&, std::shared_ptr<openage::gamestate::EntityFactory> const&)+0xcc [0x7eff2e4e72cc]
File ?, in openage::gamestate::Game::load_data(std::shared_ptr<openage::assets::ModManager> const&)+0x50 [0x7eff2e4e6900]
File ?, in ? [0x7eff2e3182e8]
File ?, in __cxa_rethrow+0x4f [0x7eff30ab043f]
File ?, in ? [0x7eff30ab0189]
File ?, in ? [0x7eff30ab011c]
File ?, in openage::error::terminate_handler()+0x10e [0x7eff2e48869e]
handing over to the system...
terminate called after throwing an instance of 'std::bad_alloc'
what(): std::bad_alloc
Annullato (core dump creato)
[fabio@archlinux ~]$
[fabio@archlinux ~]$ openage game --modpacks hd_base
INFO [py] launching openage v0.4.1-1532-g4773e70ff
INFO [py] compiled by GNU 13.2.1
INFO [py] openage nyan API modpack is up to date
INFO [py] Found modpack engine
INFO [py] Found modpack hd_base
INFO loading configuration files...
INFO [py] loading config file [Union(<openage.util.fslike.union.Union object at 0x7f4263be4550>.root @ (b'cfg',), <openage.util.fslike.union.Union object at 0x7f4263bd4650>.root @ (b'assets',))]:cfg/keybinds.oac...
INFO launching engine with root directoryPath(Union(<openage.util.fslike.union.Union object at 0x7f4263be4550>.root @ (b'cfg',), <openage.util.fslike.union.Union object at 0x7f4263bd4650>.root @ (b'assets',)):)
INFO loading configuration files...
INFO [py] loading config file [Union(<openage.util.fslike.union.Union object at 0x7f4263be4550>.root @ (b'cfg',), <openage.util.fslike.union.Union object at 0x7f4263bd4650>.root @ (b'assets',))]:cfg/keybinds.oac...
INFO Found modpack: engine
INFO Found modpack: hd_base
INFO Created game simulation
INFO Activated modpack: engine
INFO Activated modpack: hd_base
INFO Created 3 threads (24 available)
INFO [T1] Presenter: Launching subsystems...
INFO [T1] Presenter: Initializing graphics subsystems...
FATAL: terminate has been called
uncaught exception
std::exception of type std::length_error: basic_string::_M_create
current stack:
Traceback (most recent call last):
File ?, in ? [0x7f42670aa9eb]
INFO [T2] Time loop started
File ?, in ? [0x7f4265ee1943]
File ?, in ? [0x7f4263683ae9]
File ?, in openage::gamestate::GameSimulation::run()+0x2f [0x7f42636ee8cf]
File ?, in openage::gamestate::GameSimulation::start()+0xaf [0x7f42636ee6ff]
File ?, in openage::gamestate::Game::Game(std::shared_ptr<openage::event::EventLoop> const&, std::shared_ptr<openage::assets::ModManager> const&, std::shared_ptr<openage::gamestate::EntityFactory> const&)+0xcc [0x7f42636e72cc]
File ?, in openage::gamestate::Game::load_data(std::shared_ptr<openage::assets::ModManager> const&)+0x50 [0x7f42636e6900]
File ?, in ? [0x7f42635182e8]
File ?, in __cxa_rethrow+0x4f [0x7f4265eb043f]
File ?, in ? [0x7f4265eb0189]
File ?, in ? [0x7f4265eb011c]
File ?, in openage::error::terminate_handler()+0x10e [0x7f426368869e]
handing over to the system...
terminate called after throwing an instance of 'std::length_error'
what(): basic_string::_M_create
Annullato (core dump creato)
[fabio@archlinux ~]$
from openage.
heinezen
commented on May 19, 2024
@FabioLolix New plan: Please run the lates commit from the PR and paste the output here. I've added log messages to every string operation.
from openage.
FabioLolix
commented on May 19, 2024
$ openage game --modpacks hd_base
INFO [py] launching openage v0.3.0-3150-gf9abad3e
INFO [py] compiled by GNU 13.2.1
INFO [py] openage nyan API modpack is up to date
INFO [py] Found modpack engine
INFO [py] Found modpack hd_base
INFO loading configuration files...
INFO [py] loading config file [Union(<openage.util.fslike.union.Union object at 0x7fcfeb9f3cd0>.root @ (b'cfg',), <openage.util.fslike.union.Union object at 0x7fcfed7e9490>.root @ (b'assets',))]:cfg/keybinds.oac...
INFO launching engine with root directoryPath(Union(<openage.util.fslike.union.Union object at 0x7fcfeb9f3cd0>.root @ (b'cfg',), <openage.util.fslike.union.Union object at 0x7fcfed7e9490>.root @ (b'assets',)):)
INFO loading configuration files...
INFO [py] loading config file [Union(<openage.util.fslike.union.Union object at 0x7fcfeb9f3cd0>.root @ (b'cfg',), <openage.util.fslike.union.Union object at 0x7fcfed7e9490>.root @ (b'assets',))]:cfg/keybinds.oac...
INFO Found modpack: engine
INFO Found modpack: hd_base
INFO Created game simulation
INFO Activated modpack: engine
INFO Activated modpack: hd_base
INFO Created 3 threads (24 available)
INFO [T1] parts: 1
INFO [T1] last_part: **
INFO [T1] search before: **
INFO [T1] B0 parts size: 1
INFO [T1] B1 search:
INFO [T3] Presenter: Launching subsystems...
INFO [T3] Presenter: Initializing graphics subsystems...
INFO [T2] Time loop started
INFO [T1] Loading .nyan file: engine/resistance/property/type.nyan
INFO [T1] Loading .nyan file: engine/util/distribution_type.nyan
INFO [T1] Loading .nyan file: engine/root.nyan
INFO [T1] Loading .nyan file: engine/util/calculation_type.nyan
INFO [T1] Loading .nyan file: engine/resistance/property.nyan
INFO [T1] Loading .nyan file: engine/util/cost.nyan
INFO [T1] Loading .nyan file: engine/util/payment_mode.nyan
INFO [T1] Loading .nyan file: engine/resistance/continuous.nyan
INFO [T1] Loading .nyan file: engine/resistance.nyan
INFO [T1] Loading .nyan file: engine/resistance/discrete.nyan
INFO [T1] Loading .nyan file: engine/resistance/continuous/time_relative_progress.nyan
INFO [T1] Loading .nyan file: engine/util/progress_type.nyan
INFO [T1] Loading .nyan file: engine/resistance/continuous/time_relative_progress/type.nyan
INFO [T1] Loading .nyan file: engine/resistance/continuous/time_relative_attribute/type.nyan
INFO [T1] Loading .nyan file: engine/resistance/continuous/time_relative_attribute.nyan
INFO [T1] Loading .nyan file: engine/util/attribute_change_type.nyan
INFO [T1] Loading .nyan file: engine/resistance/continuous/flat_attribute_change/type.nyan
INFO [T1] Loading .nyan file: engine/resistance/continuous/flat_attribute_change.nyan
INFO [T1] Loading .nyan file: engine/util/attribute.nyan
INFO [T1] Loading .nyan file: engine/util/language/translated/type.nyan
INFO [T1] Loading .nyan file: engine/util/language/translated.nyan
INFO [T1] Loading .nyan file: engine/util/language.nyan
INFO [T1] Loading .nyan file: engine/util/sound.nyan
INFO [T1] Loading .nyan file: engine/resistance/continuous/type.nyan
INFO [T1] Loading .nyan file: engine/util/lure_type.nyan
INFO [T1] Loading .nyan file: engine/resistance/discrete/convert/type.nyan
INFO [T1] Loading .nyan file: engine/resistance/discrete/convert.nyan
INFO [T1] Loading .nyan file: engine/util/convert_type.nyan
INFO [T1] Loading .nyan file: engine/resistance/discrete/flat_attribute_change/type.nyan
INFO [T1] Loading .nyan file: engine/resistance/discrete/flat_attribute_change.nyan
INFO [T1] Loading .nyan file: engine/resistance/discrete/type.nyan
INFO [T1] Loading .nyan file: engine/util/storage.nyan
INFO [T1] Loading .nyan file: engine/util/progress.nyan
INFO [T1] Loading .nyan file: engine/util/game_entity_type.nyan
INFO [T1] Loading .nyan file: engine/util/resource.nyan
INFO [T1] Loading .nyan file: engine/util/state_machine.nyan
INFO [T1] Loading .nyan file: engine/util/transform_pool.nyan
INFO [T1] Loading .nyan file: engine/modifier.nyan
INFO [T1] Loading .nyan file: engine/modifier/property.nyan
INFO [T1] Loading .nyan file: engine/ability.nyan
INFO [T1] Loading .nyan file: engine/ability/property.nyan
INFO [T1] Loading .nyan file: engine/util/game_entity.nyan
INFO [T1] Loading .nyan file: engine/util/variant.nyan
INFO [T1] Loading .nyan file: engine/util/patch.nyan
INFO [T1] Loading .nyan file: engine/util/patch/property.nyan
INFO [T1] Loading .nyan file: engine/util/resource_spot.nyan
INFO [T1] Loading .nyan file: engine/util/progress/property.nyan
INFO [T1] Loading .nyan file: engine/util/logic.nyan
INFO [T1] Loading .nyan file: engine/util/container_type.nyan
INFO [T1] Loading .nyan file: engine/effect.nyan
INFO [T1] Loading .nyan file: engine/effect/property.nyan
INFO [T1] Loading .nyan file: engine/ability/property/type.nyan
INFO [T1] Loading .nyan file: engine/util/lock.nyan
INFO [T1] Loading .nyan file: engine/util/graphics.nyan
INFO [T1] Loading .nyan file: engine/util/animation_override.nyan
INFO [T1] Loading .nyan file: engine/util/diplomatic_stance.nyan
INFO [T1] Loading .nyan file: engine/ability/type.nyan
INFO [T1] Loading .nyan file: engine/util/trade_route.nyan
INFO [T1] Loading .nyan file: engine/util/terrain_type.nyan
INFO [T1] Loading .nyan file: engine/util/terrain.nyan
INFO [T1] Loading .nyan file: engine/util/create.nyan
INFO [T1] Loading .nyan file: engine/util/placement_mode.nyan
INFO [T1] Loading .nyan file: engine/util/hitbox.nyan
INFO [T1] Loading .nyan file: engine/util/research.nyan
INFO [T1] Loading .nyan file: engine/util/tech.nyan
INFO [T1] Loading .nyan file: engine/util/tech_type.nyan
INFO [T1] Loading .nyan file: engine/util/effect_batch.nyan
INFO [T1] Loading .nyan file: engine/util/effect_batch/property.nyan
INFO [T1] Loading .nyan file: engine/effect/discrete.nyan
INFO [T1] Loading .nyan file: engine/util/selection_box.nyan
INFO [T1] Loading .nyan file: engine/util/game_entity_stance.nyan
INFO [T1] Loading .nyan file: engine/util/production_mode.nyan
INFO [T1] Loading .nyan file: engine/effect/continuous.nyan
INFO [T1] Loading .nyan file: engine/util/accuracy.nyan
INFO [T1] Loading .nyan file: engine/util/exchange_mode.nyan
INFO [T1] Loading .nyan file: engine/util/dropoff_type.nyan
INFO [T1] Loading .nyan file: engine/util/target_mode.nyan
INFO [T1] Loading .nyan file: engine/util/exchange_rate.nyan
INFO [T1] Loading .nyan file: engine/util/price_pool.nyan
INFO [T1] Loading .nyan file: engine/util/price_mode.nyan
INFO [T1] Loading .nyan file: engine/util/passable_mode.nyan
INFO [T1] Loading .nyan file: engine/util/game_entity_formation.nyan
INFO [T1] Loading .nyan file: engine/util/formation.nyan
INFO [T1] Loading .nyan file: engine/util/herdable_mode.nyan
INFO [T1] Loading .nyan file: engine/util/move_mode.nyan
INFO [T1] Loading .nyan file: engine/modifier/resistance/flat_attribute_change/type.nyan
INFO [T1] Loading .nyan file: engine/modifier/property/type.nyan
INFO [T1] Loading .nyan file: engine/modifier/multiplier/effect/type.nyan
INFO [T1] Loading .nyan file: engine/modifier/type.nyan
INFO [T1] Loading .nyan file: engine/util/progress_status.nyan
INFO [T1] Loading .nyan file: engine/modifier/effect/flat_attribute_change/type.nyan
INFO [T1] Loading .nyan file: engine/modifier/effect/type.nyan
INFO [T1] Loading .nyan file: engine/util/terrain_type/type.nyan
INFO [T1] Loading .nyan file: engine/util/game_entity_type/type.nyan
INFO [T1] Loading .nyan file: engine/util/mod.nyan
INFO [T1] Loading .nyan file: engine/util/production_mode/type.nyan
INFO [T1] Loading .nyan file: engine/util/effect_batch/property/type.nyan
INFO [T1] Loading .nyan file: engine/util/effect_batch/type.nyan
INFO [T1] Loading .nyan file: engine/util/logic/gate.nyan
INFO [T1] Loading .nyan file: engine/util/logic/literal_scope.nyan
INFO [T1] Loading .nyan file: engine/util/logic/literal_scope/type.nyan
INFO [T1] Loading .nyan file: engine/util/logic/literal.nyan
INFO [T1] Loading .nyan file: engine/util/logic/literal/type.nyan
INFO [T1] Loading .nyan file: engine/util/logic/gate/type.nyan
INFO [T1] Loading .nyan file: engine/util/logic/const.nyan
INFO [T1] Loading .nyan file: engine/util/passable_mode/type.nyan
INFO [T1] Loading .nyan file: engine/util/modifier_scope/type.nyan
INFO [T1] Loading .nyan file: engine/util/modifier_scope.nyan
INFO [T1] Loading .nyan file: engine/util/variant/type.nyan
INFO [T1] Loading .nyan file: engine/util/attribute_change_type/type.nyan
INFO [T1] Loading .nyan file: engine/util/selection_box/type.nyan
INFO [T1] Loading .nyan file: engine/util/game_entity_stance/type.nyan
INFO [T1] Loading .nyan file: engine/util/exchange_mode/type.nyan
INFO [T1] Loading .nyan file: engine/util/diplomatic_stance/type.nyan
INFO [T1] Loading .nyan file: engine/util/patch/property/type.nyan
SIGSEGV
FATAL: terminate has been called
current stack:
Traceback (most recent call last):
File ?, in ? [0x7fcfeeeaa9eb]
File ?, in ? [0x7fcfedce1943]
File ?, in ? [0x7fcfeb483bf6]
File ?, in openage::time::TimeLoop::run()+0x3a [0x7fcfeb63055a]
File ?, in openage::time::Clock::update_time()+0x1e [0x7fcfeb62c55e]
File ?, in ? [0x7fcfeee5c710]
File ?, in ? [0x7fcfeb481c45]
File ?, in ? [0x7fcfedcb0189]
File ?, in ? [0x7fcfedcb011c]
File ?, in openage::error::terminate_handler()+0x10e [0x7fcfeb48876e]
handing over to the system...
terminate called without an active exception
Annullato (core dump creato)
from openage.
heinezen
commented on May 19, 2024
So the response makes me think that some memory corruption is going on. The strings are probably not the problem. Might be a race condition in the threads. But without active debugging, this could be hard to detect. I have to give up here for now and think what the cause could be.
from openage.
heinezen
commented on May 19, 2024
I set up an Arch environment yesterday and could reproduce the error! Will check what caused it today.
from openage.
heinezen
commented on May 19, 2024
It's a build optimization problem. The error appears in RelWithDebInfo mode but not in Debug. Classic Heisenbug.
from openage.
FabioLolix
commented on May 19, 2024
Thank you very much, the problem happen with Release and None too
from openage.
heinezen
commented on May 19, 2024
Looks like this is what causes trouble:
https://github.com/SFTtech/openage/blob/master/libopenage/engine/engine.cpp#L77
The line is optimized out and Engine is destroyed which cause all sorts of problems.
from openage.
heinezen
commented on May 19, 2024
Fix in #1578
from openage.
FabioLolix
commented on May 19, 2024
I'll tests later thanks
from openage.
heinezen
commented on May 19, 2024
I've added another commit that should address this issue permanently
from openage.
FabioLolix
commented on May 19, 2024
I'll test tomorrow thanks
from openage.
heinezen
commented on May 19, 2024
@FabioLolix Did you get around testing it? If everything works, we will do a bugfix release.
from openage.
Related Issues (20)
- Can't build with clang, error: "jthread is supported now, remove custom definition" HOT 4
- Asset conversion issue, AttributeError: 'NoneType' object has no attribute 'readable' HOT 6
- Adding PR/ISSUE Templates for this repo HOT 7
- Asset path type is incorrectly used HOT 5
- error: Couldn't find qml root folder HOT 15
- Test fail when building with GCC 13.2.1 HOT 10
- openage game: error: the following arguments are required: --modpacks HOT 4
- Running Error on Mac osx 13.4(Macbook M1 Pro ARM architecture) HOT 1
- FATAL: terminate has been called uncaught exception std::exception of type std::__1::system_error: thread::join failed: Invalid argument HOT 2
- Multiple cmake issues when trying to build HOT 4
- Submission to Steam HOT 2
- OpenGL error when launching on Wayland HOT 11
- CMake can't find toml11 on Linux Mint 21.2 HOT 4
- Errors after the new PR merged HOT 3
- Link on website https://openage.sft.mx/ to windows packages is a broken link HOT 2
- Windows Build: Python Command Requiring --modpacks Argument HOT 3
- Asset conversion stalls on media conversion HOT 11
- Fix Ubuntu Dependency installation script HOT 5
- Build failing, unable to find Python3 on Windows 10 HOT 15
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openage.