Code Monkey home page Code Monkey logo

Comments (3)

sfackler avatar sfackler commented on July 17, 2024

Which method in particular do you think you need to do that check for? tokio-tls, for example, doesn't need to do that: https://github.com/tokio-rs/tokio-tls/blob/master/src/lib.rs

from rust-native-tls.

osa1 avatar osa1 commented on July 17, 2024

Sorry for late response,

It's interesting that tokio-tls doesn't need that. It may be because:

  • They use an underlying stream type that handles EWOULDBLOCKs correctly (in our case we use https://github.com/osa1/tiny/blob/master/src/stream/tcp.rs).
  • Their implementation is also broken. I recently discovered that if I use 1.0.2g (dynamically linked) my code works fine. If I use 1.1.0g (statically linked) it doesn't. (tracking issue osa1/tiny#64)

My original request was a function of type fn(native_tls::Error) -> bool that checks if the error is caused by EWOULDBLOCK, but this may not be necessary when the underlying stream implemented correctly. I'll try to see if there's a problem with our TcpStream implementation.

from rust-native-tls.

osa1 avatar osa1 commented on July 17, 2024

Closing this as I no longer need this.

from rust-native-tls.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.