Allow Backend Customization about rust-native-tls HOT 8 CLOSED

There are extension traits for each backend that let you get at the internals. Here are the ones for OpenSSL for example: https://docs.rs/native-tls/0.1.2/native_tls/backend/openssl/index.html.

But if you specifically want to use OpenSSL, why are you using native-tls rather than openssl directly?

from rust-native-tls.

While I'm using only OpenSSL at the moment, it may change to rustls and using the TlsAcceptor struct would simplify integration. Part of the value for this crate is the common interface that TlsAcceptor allows.

Take tokio-tls for example, I could write my own implementation of TlsAcceptorExt using SslAcceptor directly, but that seems unnecessary because tokio-tls already defines an implementation using TlsAcceptor and the openssl implementation of TlsAcceptor only wraps an SslAcceptor. I figured I could leverage code already written if I could have TlsAcceptor directly instantiated from an SslAcceptor.

The reason why I'm not using TlsAcceptor::builder(<pkcs12>) is because I use pem, and forcing a conversion to pkcs12 is not ideal.

from rust-native-tls.

This crate doesn't support rustls.

from rust-native-tls.

I know bad example -- I was talking hypothetically -- still I find it a possibility that an app, depending on where it is deployed, will want to provide TLS capabilities that don't fall into using pkcs file format and needs cipher suite customization. Maybe this app will use pkcs on osx, pem on linux, and der on windows -- each with a different set of supported cipher suites. This is an odd use case, certainly, but I don't think should be disallowed especially because as far as I can tell, this is possible if all implementations of TlsAcceptor are exposed.

from rust-native-tls.

Sure - that's why those extension traits exist.

from rust-native-tls.

Yes, but I can't instantiate either TlsAcceptorBuilder or TlsAcceptor:

Given:

use openssl::ssl::{SslMethod, SslAcceptorBuilder, SslAcceptor};
use native_tls::{TlsAcceptor, TlsAcceptorBuilder};
use native_tls::backend::openssl::TlsAcceptorBuilderExt;
// etc

let builder = SslAcceptorBuilder::mozilla_intermediate(SslMethod::tls(), &pkey, &pcert, it)?;
// TlsAcceptorBuilder(builder).build();
// TlsAcceptor(builder.build());

Will both fail if either is uncommented with the error.

did you mean `TlsAcceptorBuilder { /* fields */ }`?
constructor is not visible here due to private fields

And I can't use TlsAcceptor::builder because I don't use pkcs12 🤔

Am I missing something obvious?

from rust-native-tls.

Ah - we should just add a constructor method to TcpAcceptorExt.

from rust-native-tls.

(The extension traits basically contain whatever people have needed up to now)

from rust-native-tls.