Comments (8)
What I think I will do is use pycodestyle
directly instead of using pytest-pycodestyle
. This will get rid of the old pep8
module while using something that works for the versions natsort
supports.
from natsort.
Please make a pull request for this change.
from natsort.
Sorry, I can't. I am only a maintainer of the port.
I only tried to avoid creation of the unnecessary package.
from natsort.
I don’t understand why being a maintainer of the port means you cannot create a pull request. I will accept a pull request from anyone no matter their relationship to the code. I am not asking you to be a long term contributor.
from natsort.
I have no resources to fix issues in individual projects. I also have no idea what pep8 is for. So I would have to learn first what is it for, and this isn't going to be cost effective compared to this being done by someone who added pep8 there in the first place.
from natsort.
I will make this change because your reasoning sounds valid.
Some free advice
Please keep in mind that like yourself, the developers of the libraries and tools that you are creating ports for do so in their spare time. If there is a bug, a developer fully expects that it is on them to investigate and fix the bug. However, when someone asks for a specific change that does not actually fix a bug and does not provide a new feature, there is often an expectation that the asker will contribute at least some of the work; if one just says "change this thing" without offering to help then it comes across like the developer owes the asker something or that the developer is working for the asker, both of which can lead to negative feelings.
I understand why there was no accompanying PR with this issue. In the future, things could go a bit more smoothly if instead of just pointing out the problem (which comes across as complaining) an explanation of the situation could be added -- something like the following:
Hi, can you please change
<this>
to<that>
since<this>
has been deprecated in favor of
<that>
. I would like to help, but am just the BSD port maintainer and don't actually have enough
experience with python to actually make this change.
I think that it is important for maintainers of ports/packages and developers of the libraries they package to establish good relationships with each other, and a slightly less "matter-of-fact" tone when filing issues can go long way to this end.
from natsort.
It turns out that the maintainer of pytest-pycodestyle
will not support Python 2.7 or Python 3.4: see henry0312/pytest-pycodestyle#36 for details. Since natsort
supports these versions, it will become an unnecessary hardship to use pytest-pep8
for those versions and then pytest-pycodestyle
for the newer versions. Until either a) natsort
drop support for those versions or b) pytest-codestyle
adds support, I will continue to use pytest-pep8
.
from natsort.
Ok, this is totally fine.
Thanks!
from natsort.
Related Issues (20)
- Can't use natsort_keygen() as key for sorting DataFrame with MultiIndex in pandas HOT 3
- Some values don't sort in a consistent order HOT 3
- Set which OS to sort by in `os_sorted` HOT 8
- Paths should be sorted like strings HOT 6
- Loosen types and type checking
- Sorting a list of dictionaries when the sort field might or might not have a number HOT 2
- Improve os_sorted performance by avoiding `Path` roundtrips HOT 1
- add a mode for hexadecimal numbers HOT 7
- 1 test fails HOT 5
- RFE: drop use `m2r2` module HOT 8
- Sorting income category with both string and num HOT 1
- compatibility with GNU coreutils sort -n (numeric sort) HOT 14
- 'os_sorted' sorts files with spaces in names not as in Windows Explorer HOT 2
- not consistent with behavior of windows chinese edition HOT 1
- `cmp_to_key` gives an error and I don't know if this is a bug or just not supported HOT 3
- wiki pages so huge that they are not loaded properly HOT 2
- Error while sorting dates if `NaT` HOT 3
- Unexpected natural sort when sorting multi-dimensional arrays or `pandas.DataFrame` HOT 14
- Support Python 3.12 HOT 2
- Character based sorting HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from natsort.