Code Monkey home page Code Monkey logo

Comments (8)

SethMMorton avatar SethMMorton commented on August 13, 2024 1

What I think I will do is use pycodestyle directly instead of using pytest-pycodestyle. This will get rid of the old pep8 module while using something that works for the versions natsort supports.

from natsort.

SethMMorton avatar SethMMorton commented on August 13, 2024

Please make a pull request for this change.

from natsort.

yurivict avatar yurivict commented on August 13, 2024

Sorry, I can't. I am only a maintainer of the port.
I only tried to avoid creation of the unnecessary package.

from natsort.

SethMMorton avatar SethMMorton commented on August 13, 2024

I don’t understand why being a maintainer of the port means you cannot create a pull request. I will accept a pull request from anyone no matter their relationship to the code. I am not asking you to be a long term contributor.

from natsort.

yurivict avatar yurivict commented on August 13, 2024

I have no resources to fix issues in individual projects. I also have no idea what pep8 is for. So I would have to learn first what is it for, and this isn't going to be cost effective compared to this being done by someone who added pep8 there in the first place.

from natsort.

SethMMorton avatar SethMMorton commented on August 13, 2024

I will make this change because your reasoning sounds valid.

Some free advice

Please keep in mind that like yourself, the developers of the libraries and tools that you are creating ports for do so in their spare time. If there is a bug, a developer fully expects that it is on them to investigate and fix the bug. However, when someone asks for a specific change that does not actually fix a bug and does not provide a new feature, there is often an expectation that the asker will contribute at least some of the work; if one just says "change this thing" without offering to help then it comes across like the developer owes the asker something or that the developer is working for the asker, both of which can lead to negative feelings.

I understand why there was no accompanying PR with this issue. In the future, things could go a bit more smoothly if instead of just pointing out the problem (which comes across as complaining) an explanation of the situation could be added -- something like the following:

Hi, can you please change <this> to <that> since <this> has been deprecated in favor of
<that>. I would like to help, but am just the BSD port maintainer and don't actually have enough
experience with python to actually make this change.

I think that it is important for maintainers of ports/packages and developers of the libraries they package to establish good relationships with each other, and a slightly less "matter-of-fact" tone when filing issues can go long way to this end.

from natsort.

SethMMorton avatar SethMMorton commented on August 13, 2024

It turns out that the maintainer of pytest-pycodestyle will not support Python 2.7 or Python 3.4: see henry0312/pytest-pycodestyle#36 for details. Since natsort supports these versions, it will become an unnecessary hardship to use pytest-pep8 for those versions and then pytest-pycodestyle for the newer versions. Until either a) natsort drop support for those versions or b) pytest-codestyle adds support, I will continue to use pytest-pep8.

from natsort.

yurivict avatar yurivict commented on August 13, 2024

Ok, this is totally fine.

Thanks!

from natsort.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.