Comments (5)
I'm seeing this one as well.
from servo.
I think there's a similar failure on the CI as well in /_mozilla/mozilla/window_resizeTo.html
(https://github.com/servo/servo/actions/runs/8646629393/job/23707588657#step:8:2099):
CRASH [expected OK] /_mozilla/mozilla/window_resizeTo.html
│
│ assertion `left == right` failed
│ left: (1281, 36053)
│ right: (0, 36053) (thread main, at /home/runner/work/servo/servo/components/compositing/compositor.rs:2268)
│ 0: servoshell::backtrace::print
│ 1: servoshell::main::{{closure}}
│ 2: <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call
│ at /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/alloc/src/boxed.rs:2021:9
│ std::panicking::rust_panic_with_hook
│ at /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/std/src/panicking.rs:735:13
│ 3: std::panicking::begin_panic_handler::{{closure}}
│ at /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/std/src/panicking.rs:609:13
│ 4: std::sys_common::backtrace::__rust_end_short_backtrace
│ at /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/std/src/sys_common/backtrace.rs:170:18
│ 5: rust_begin_unwind
│ at /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/std/src/panicking.rs:597:5
│ 6: core::panicking::panic_fmt
│ at /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/core/src/panicking.rs:72:14
│ 7: core::panicking::assert_failed_inner
│ 8: core::panicking::assert_failed
│ 9: compositing::compositor::IOCompositor<Window>::clear_background
│ 10: profile_traits::time::profile
│ 11: compositing::compositor::IOCompositor<Window>::composite_specific_target
│ 12: compositing::compositor::IOCompositor<Window>::composite
│ 13: compositing::compositor::IOCompositor<Window>::perform_updates
│ 14: servo::Servo<Window>::handle_events
│ 15: servoshell::app::App::handle_events
│ 16: servoshell::events_loop::EventsLoop::run_forever
│ 17: servoshell::app::App::run
│ 18: servoshell::main
│ 19: std::sys_common::backtrace::__rust_begin_short_backtrace
│ 20: std::rt::lang_start::{{closure}}
│ 21: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
│ at /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/core/src/ops/function.rs:284:13
│ std::panicking::try::do_call
│ at /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/std/src/panicking.rs:504:40
│ std::panicking::try
│ at /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/std/src/panicking.rs:468:19
│ std::panic::catch_unwind
│ at /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/std/src/panic.rs:142:14
│ std::rt::lang_start_internal::{{closure}}
│ at /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/std/src/rt.rs:148:48
│ std::panicking::try::do_call
│ at /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/std/src/panicking.rs:504:40
│ std::panicking::try
│ at /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/std/src/panicking.rs:468:19
│ std::panic::catch_unwind
│ at /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/std/src/panic.rs:142:14
│ std::rt::lang_start_internal
│ at /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/std/src/rt.rs:148:20
│ 22: main
│ 23: <unknown>
│ 24: __libc_start_main
│ 25: _start
│ mozilla::detail::MutexImpl::~MutexImpl: pthread_mutex_destroy failed: Device or resource busy
│ Caught signal 11thread panicked while processing panic. aborting.
│ Redirecting call to abort() to mozalloc_abort
└
from servo.
Fullscreen seems fine on Windows. I'll test Linux later and triage macOS further on.
from servo.
So GL error 1281 means invalid input. This is because the webview flipped origin got way off in clear_background method when the window became fullscreen:
[components/compositing/compositor.rs:2257] &rect.min = (
0,
0,
)
[components/compositing/compositor.rs:2257] &rect.min = (
0,
1060,
)
assertion `left == right` failed
left: (1281, 36053)
right: (0, 36053) (thread main, at /Users/wuwayne/Desktop/servo/components/compositing/compositor.rs:2269)
[2024-04-13T04:13:37Z ERROR servoshell] assertion `left == right` failed
left: (1281, 36053)
right: (0, 36053)
And this is due to webview coordinate not being updated yet when window became fullscreen initially. It's a little late and being updated during egui minibrowser update.
from servo.
I found out the flip_rect
method isn't quite correct either. Will open another PR to fix it.
from servo.
Related Issues (20)
- [webgpu] poller.wait() should call maintain in this thread
- Update link to `selectors` crates in `rust-selectors` repo
- Add pref for wgpu backend HOT 2
- Fix support for the DevTools protocol
- Collapsed table tracks are wrong with spanning cells
- [bluetooth] Replace IPC channel with GenericChannel HOT 6
- Docs are not built for libservo HOT 2
- mach doc hangs and eventually crashes on wgpu-core(doc) HOT 5
- Enable gl(es) backend in wgpu HOT 4
- Unified thread pool and async runtime
- Servo hangs on X11 XFCE if not running with Background Hang Monitor enabled
- servo crashes when trying to load www.startpage.com
- See if there are performance benefits to be had from not doing IB-splits HOT 1
- Image Cache: clarify, and perhaps fix, image decoding HOT 4
- Minibrowser: Hiding URL bar in fullscreen is a phishing risk
- Remove duplicated generate_cache_listener_for_element code
- Strange log when using servo-media in android HOT 1
- [Bug]: Arabic and Persian characters rendered in horizontal reverse HOT 1
- HTML parser does not support reentrancy via custom elements HOT 9
- Text rendering issue in servo.org footer
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from servo.