Comments (9)
But it seems it #31517 (comment) even more threads.
Yes that's correct, it uses a threadpool which will see threads created upfront, instead of spawning one thread for each image that is decoded.
I'm wondering if we could make whole net crate to share the same tokio runtime without manually spawning threads and thread pool.
We can use a single runtime for all async task, and a single core resource threadpool for the other non-async bacground work.
from servo.
@gterzian Could you add some good-first-issue or E-candidate-for-mentoring label?
This issue seems like a good chance for anyone who want to contribute.
from servo.
I would like to take this up.
from servo.
I saw your comment in zulip mentioned there's another PR dealing with thread spawning too. But it seems it created even more threads. I'm wondering if we could make whole net
crate to share the same tokio runtime without manually spawning threads and thread pool.
from servo.
Hey @tannal what is your status with the issue. Can I join
from servo.
@MunishMummadi Yes you can.
The quick fix for this issue is done.
We can use a single runtime for all async task, and a single core resource threadpool for the other non-async bacground work.
You can open another pr to do this part if you are interested in this issue.
from servo.
a single core resource threadpool for the other non-async bacground work.
Yes indeed, this part would be good for a new PR @MunishMummadi
The idea is to use a single CoreResourceThreadPool
in components/net
, see for guidance this issue, which added a second one. You could make changes to have a single pool used where now two are used.
from servo.
Yes I would love to work on it @gterzian @tannal . Can I ask the bot to "assign me"!!!
from servo.
Actually, because the image cache runs in the script thread, not in the core resource thread, this is quite complicated and perhaps not a good idea. I withdraw my earlier conclusion.
from servo.
Related Issues (20)
- [webgpu] poller.wait() should call maintain in this thread
- Update link to `selectors` crates in `rust-selectors` repo
- Add pref for wgpu backend HOT 2
- Fix support for the DevTools protocol
- Collapsed table tracks are wrong with spanning cells
- [bluetooth] Replace IPC channel with GenericChannel HOT 6
- Docs are not built for libservo HOT 2
- mach doc hangs and eventually crashes on wgpu-core(doc) HOT 5
- Enable gl(es) backend in wgpu HOT 4
- Unified thread pool and async runtime
- Servo hangs on X11 XFCE if not running with Background Hang Monitor enabled
- servo crashes when trying to load www.startpage.com
- See if there are performance benefits to be had from not doing IB-splits HOT 1
- Image Cache: clarify, and perhaps fix, image decoding HOT 4
- Minibrowser: Hiding URL bar in fullscreen is a phishing risk
- Remove duplicated generate_cache_listener_for_element code
- Strange log when using servo-media in android HOT 1
- [Bug]: Arabic and Persian characters rendered in horizontal reverse HOT 1
- HTML parser does not support reentrancy via custom elements HOT 9
- Text rendering issue in servo.org footer
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from servo.