join() broken handling of URL with colon in path about rust-url HOT 4 CLOSED

The problem is that "WEB-v2:gizmo" parses as a URL.

I get the same results using the Reference URL parser

Or using JS in the browser:

let base = new URL("https://example.org/lorem/");
// undefined
let u = new URL("WEB-v2:gizmo", base)
// undefined
u.href
// "web-v2:gizmo" 

If you need to use join just prepend ./ to the string you want to use if you know it's a path.
Or use set_path as you indicated you can do.

from rust-url.

I understand the logic, but is the join() method really serving a purpose by being so dumb?

Anyone who looks at URL "https://example.org/lorem/" and is asked to join "WEB-v2:gizmo" to it can come up with the intended result. But this method can not, even though it's the explicit, stated purpose of a method from a library dedicated to parsing URLs.

from rust-url.

I agree that the API design is not great. Ideally this wouldn't be a method on the URL object, but a static name like Url::parse_with_base that makes it clear what the method does.
Absent that, you have the documentation: https://docs.rs/url/latest/url/struct.Url.html#method.join

Parse a string as an URL, with this URL as the base URL.

from rust-url.

Makes sense. Thanks for explanation!

from rust-url.