Windows paths into URLs about rust-url HOT 5 CLOSED

Would that be file:/// plus the bytes that remain with \ replaced with / and URL encoded?

Put another way—given that the path is not necessarily legal UTF-16, what do we do for non-ASCII paths?

from rust-url.

Fixed in 36d22de. The reason this was not implemented is that std::path::windows::Path is relatively complex (see PathPrefix in particular), and I don’t know what to do with UNC and other prefixes other than disk. For now they just return Err.

from rust-url.

@chris-morgan It’s unclear to me whether windows filenames are necessarily legal UTF-16. But since std::path::windows::Path uses an UTF-8 String internally, this is already an issue in libstd. rust-url just uses the bytes returned by Path::components and percent-encodes that.

from rust-url.

And, Url::to_file_path was similarly fixed in 286c8f7.

from rust-url.

Thanks @SimonSapin!

from rust-url.