Cannot parse usernames in path urls. about rust-url HOT 6 CLOSED

You are trying to parse an URL with an authority (scheme://authority), an authority must include a non-empty host.

from rust-url.

Oh wait, no, I stand corrected:

      reg-name    = *( unreserved / pct-encoded / sub-delims )

from rust-url.

FWIW

new URL("postgres://postgres@/var/run/postgresql").username === ""

is true for both Firefox and Chrome

from rust-url.

@alexcrichton Not sure why I didn’t respond to this a year ago, sorry. To use "non-standard" schemes like postgres: you probably want a custom "scheme type mapper" https://servo.github.io/rust-url/url/struct.UrlParser.html#method.scheme_type_mapper .

@nox Where is that quote from? This crates implements http://url.spec.whatwg.org/ which sometimes diverges from the various relevant IETF RFCs.

@frewsxcv The Rust API of this crate and its behavior is not necessarily the same as https://url.spec.whatwg.org/#api (which is designed for JavaScript and web compat) as long as it enables Servo to implement it on top.

from rust-url.

The Rust API of this crate and its behavior is not necessarily the same as https://url.spec.whatwg.org/#api (which is designed for JavaScript and web compat) as long as it enables Servo to implement it on top.

I thought about that possibility, but wasn't sure. Thanks for clarifying 👍

from rust-url.

This passes in 1.0:

    let mut url = Url::from_file_path(filename).unwrap();
    url.set_scheme("postgres").unwrap();
    url.set_host(Some("")).unwrap();
    url.set_username("me").unwrap();
    assert_eq!(url.as_str(), "postgres://me@/run/pg.sock");

The idea is that you can’t have a username without a host, but an empty host is not the same as no host. It’s not clear whether empty hosts make sense though, so I don’t know if it’s a good idea to rely on them. (The spec might change to forbid them and I’ll update rust-url to follow.) set_host(Some("localhost")) would be safe, though.

from rust-url.