Code Monkey home page Code Monkey logo

Comments (4)

sigmavirus24 avatar sigmavirus24 commented on July 4, 2024

I agree that in this case it's confusing but I'm confused about what you expect it to print out? Frankly I would expect an example with file:///home/alexcrichton/path/to/some.txt to be a more useful test of this functionality.

from rust-url.

SimonSapin avatar SimonSapin commented on July 4, 2024

to_file_path doesn’t have a type parameter anymore, but other than that this behavior hasn’t changed. Still, it matches the doc-comment. What outcome would you rather have?

Assuming the URL is in the file scheme or similar, convert its path to an absolute std::path::Path.

Note: This does not actually check the URL’s scheme, and may give nonsensical results for other schemes. It is the user’s responsibility to check the URL’s scheme before calling this.

# use url::Url;
# let url = Url::parse("file:///etc/passwd").unwrap();
let path = url.to_file_path();

Returns Err if the host is neither empty nor "localhost", or if Path::new_opt() returns None. (That is, if the percent-decoded path contains a NUL byte or, for a Windows path, is not UTF-8.)

from rust-url.

dtolnay avatar dtolnay commented on July 4, 2024

Based on the function's documentation, it seems like this is behaving correctly. What action is this issue tracking?

from rust-url.

SimonSapin avatar SimonSapin commented on July 4, 2024

Closing as working as intended / document. Feel free to reopen or comment.

from rust-url.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.