Comments (6)
This is a wilful violation of the spec. Spec issue: https://www.w3.org/Bugs/Public/show_bug.cgi?id=26446
from rust-url.
@valenting Do you or other people in the Necko team have an opinion on this? That is, as far as the parser is concerned, should the port number be a string of decimal digits (with no length limit), a 16-bit integer (matching TCP and UDP), or something else? I believe it’s currently a 32-bit integer in Gecko.
from rust-url.
I think the reason it's an int32_t in Gecko is that for a URL with a default port number, we represent it as -1.
I have been considering rejecting invalid port numbers for a while now.
rust-url has the benefit of being able to represent it as None, so as far as I'm concerned, it would be best to represent it as a u16.
from rust-url.
Would Maybe<uint16_t>
(from mfbt/Maybe.h
) work to represent Option<u16>
?
from rust-url.
I think so, but at this point it's too late to change the APIs.
We can however restrict the parsing of port numbers to the uint16_t range. I expect the spec will eventually be changed to express that constraint.
from rust-url.
The spec now agrees with rust-url on this.
“Make port either null or a 16-bit integer.” whatwg/url@c3a454c
from rust-url.
Related Issues (20)
- No hostname format validation in URL HOT 5
- The input urls generated by the fuzzer can be problematic as it causes very long parse times
- Incorrect error when url contains number sign HOT 1
- URI and IRI support? HOT 1
- `form_urlencoded::ByteSerialize` does NOT conform to the URL standard HOT 1
- Why is IP convert to Domain HOT 3
- perf: Use `NonZeroU16` for port numbers
- Url with quote after schema is getting parsed as valid. HOT 13
- v2.5.1 breaking crates.io CI HOT 1
- MSRV bump 1.67 in v2.5.1 HOT 23
- idna `to_unicode()` API has degraded in 1.0 HOT 10
- Massive regression in compile times HOT 20
- data-url: Fuzzed data URL causes high memory usage
- Upgrade to 2.5.1 breaks compilation on Windows HOT 3
- Upgrading url downgrades idna HOT 1
- URL 2.5.x 4+MB in size after optimised build. HOT 5
- The incorrect implementation of `set_scheme` for `file://`
- Calling `port()` with a default port returns None unexpectedly HOT 1
- Support for `wasm32-wasip2` target
- Make `ParseError` exhaustive HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-url.