Comments (5)
Just to share that I've found the simple workaround to embed the external interface (from another package), to a local interface (same package) that is getting referenced by weaver.Implement. The code generation works fine.
from weaver.
Thanks for reporting. Yes, we made a conscious decision not to support implementations of out-of-package interfaces, at least for now. @mwhittaker will have more state on this.
from weaver.
Hi @ghazimuharam! Here's the code in weaver generate
that disallows a struct from implementing a component interface outside its package:
weaver/internal/tool/generate/generator.go
Lines 357 to 360 in 35727ae
As Srdjan said, this was a conscious decision. I don't remember exactly why we made this decision; it might have just been a simplifying assumption for our initial release. Let me think harder about whether there's any disadvantages to allowing a component implementation to be in a separate package from its component interface. If there's none, I can take a stab at relaxing the restriction!
from weaver.
Thank you, @spetrovic77 and @mwhittaker, for responding to my issue. As this appears to be a result of conscious decisions, I understand that I may need to wait for further clarification. However, please do not hesitate to reach out if you require any help from me. In the meantime, I will try to familiarize myself with the entire repository.
from weaver.
We explored the idea of allowing component interfaces and implementations to be in separate packages in #282 but ultimately decided to disallow it. In #285, we're updating an error message to suggest @jpearll's workaround.
from weaver.
Related Issues (20)
- `weaver generate` fails when a component uses a router whose routing key is a struct
- How to properly make dependency injection with ServiceWeaver HOT 5
- Feature Request: weaver struct tags for weaver.WithConfig[T] HOT 2
- Multi Deployer Error: capture stdout EOF HOT 11
- Are there any plans to have weaver for java lang HOT 1
- AWS ECS deployer support HOT 3
- Issues with Logging Functionality and Incomplete Logs in Weaver Multi Deployment HOT 4
- Restrict service instances HOT 8
- Question: How to create multiple http services HOT 4
- Stream Listener <-> Storage HOT 4
- Limit maximum of replication HOT 5
- Synchronized component implementation (feature idea) HOT 4
- TestExamples failing: no such file HOT 1
- Bazel Support HOT 6
- Extending telemetry
- Gen client API please :)
- feat: add check rules to avoid cycle Ref HOT 2
- wasm
- The dashboard seems a little unusual. HOT 1
- 0.21.2 was not completed HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from weaver.