Code Monkey home page Code Monkey logo

Comments (2)

flowchartsman avatar flowchartsman commented on July 18, 2024 1

Could you please provide a bit more detail on why this was closed? Specifically, I think it could help to clarify how slog integration is not possible. From where I sit, the necessity of intercepting all logs does not preclude using slog, and I have an internal service library implementation that does exactly this via a common logging interface, while also providing access to creating new handlers through a well-defined interface layer. What's to prevent ServiceWeaver from adopting a similar approach? If you enumerate the difficulties or concerns, it could serve as a useful starting point for a PR from someone with experience integrating the slog package. At the very least, this issue could serve as a guideline for exactly why slog can't be used, and could be linked from the documentation to prevent any further issues or PR requests.

Given that slog is intended to serve as a stdlib-standard interface to structured logging, would you consider reopening this issue until the proposal lands? Maybe change the issue title to something like "Investigate integrating the proposed slog package"

from weaver.

spetrovic77 avatar spetrovic77 commented on July 18, 2024

Thanks for reporting.

Our logger API is based on the slog api. However, our logger needs to intercept all the logs, in order to store them in the appropriate logs storage (e.g., Google Cloud Logging, local files). So we can't use the slog package directly.

from weaver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.