Rootless operation by default about batphone HOT 2 CLOSED

I'd go a little further and say that we only publish one version of the software. We simply don't probe for root & adhoc support automatically. But the button to probe for root and adhoc support should be easily reachable, within 2 clicks of the main screen. And we may inform the user of this capability during the setup wizard dialogs.

A possible UI design;

• Wifi mode control on the main UI.
• on pressing the mode control button, the list of available modes is displayed.
• adhoc is always listed but is styled differently based on our knowledge of previous tests.
• if we have not yet checked for adhoc & root support, we indicate that we don't know if it will work. Perhaps with a question mark and / or colour styling.
• if adhoc testing failed, it may be indicated with a cross or by being greyed out.
• even if we know that testing has previously failed, if adhoc is selected we show a dialog talking about adhoc, warning the user about what we're going to do, then test if we can get adhoc working and show the results.
• if we have tested adhoc and it worked, adhoc is styled the same as the other modes and selecting it will simply change modes.

If adhoc is not known to work, we must never attempt to cycle to this mode, nor run the su binary, from any other part of the application.

from batphone.

The power switch has been redesigned to open a network selection activity. Any attempt to obtain root access or test for adhoc support is now only executed when the user manually chooses to test for adhoc support.

from batphone.