Typos in ref ids are not detected about openapi-schema-validator HOT 4 CLOSED

Hi,

thanks for reporting!

It should check for invalid refs (see

But apparently your case falls between the cracks.

I will check!

Kind regards,
Hans

from openapi-schema-validator.

ok, I checked and its a bit tricky :-)

Up until now validation only checked if the specification matched the JSONschema for that specification.
Your example matches the schema as the JSONschema of OpenAPI 3.0.0 allows for the $ref at the place where you put them, and the value of the $ref is a string as required by the JSONschema of OpenAPI 3.0.0. Hence the validator said that your schema is valid.

Since we can't validate the $ref via the JSONschema, there needs to be an extra logic check. This check was already present in resolveRefs but if you were doing a pure validation then resolveRefs would not be called as resolveRefs modifies the schema, which might be undesirable.

I have a PR in the works that adds a ref check to validation so that a specification that matches the JSONschema of OpenAPI but holds invalid refs is still marked as invalid.

Kind regards,
Hans

from openapi-schema-validator.

Released as 2.1.3 on NPM.

npx -p @seriousme/openapi-schema-validator validate-api "invalid.spec.yaml" should work correctly now.

Kind regards,
Hans

from openapi-schema-validator.

Great, thanks for such a quick fix! Everything looks cool now)

from openapi-schema-validator.