Code Monkey home page Code Monkey logo

Comments (7)

SergioBenitez avatar SergioBenitez commented on May 3, 2024 1

What's the use case for knowing the HTTP version? I'll look into making the remote_addr available.

from rocket.

SergioBenitez avatar SergioBenitez commented on May 3, 2024 1

I believe in keeping the API as clean and simple as possible. If there's something that's unused 99% of the time with little reason to use it the rest, I don't believe that feature should be included. That may or may not be the case with exposing the HTTP version - I've personally never had a need for it. Still, I'll tag this "feedback wanted"; perhaps someone else has a good reason to have it exposed.

from rocket.

imp avatar imp commented on May 3, 2024

Well, I agree that HTTP version may not appear immediately useful. However, in general hiding this kind of information gives you little, while exposing as much as possible will definitely give your users things to experiment with.

from rocket.

chris-morgan avatar chris-morgan commented on May 3, 2024

Remote address is definitely useful. Many types of apps want to record the remote IP address for audit logs.

It’s also quite plausible that you might want to implement things differently in HTTP/1.1 and HTTP/2.0, e.g. bundle things up for HTTP/1.1 or use server push of more smaller resources in HTTP/2.0.

from rocket.

SergioBenitez avatar SergioBenitez commented on May 3, 2024

I have no qualms about exposing the remote address. I'm looking for use cases on exposing the HTTP version. I'm not sure returning different responses depending on the HTTP version is something I want Rocket to encourage or allow.

from rocket.

SergioBenitez avatar SergioBenitez commented on May 3, 2024

Since no one has chimed in about a reason to expose the HTTP version, it will not be exposed.

from rocket.

mrkishi avatar mrkishi commented on May 3, 2024

e.g. bundle things up for HTTP/1.1 or use server push of more smaller resources in HTTP/2.0.

Why wouldn't you want to encourage this? Is there a better way to deal with bundled/unbundled resources in Rocket already?

from rocket.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.