sergio70 / aceeditorv14 Goto Github PK

View Code? Open in Web Editor NEW

5.0 2.0 5.0 16.06 MB

AceEditor Vaadin14

License: Other

Java 66.85% JavaScript 33.15%

aceeditorv14's Introduction

Ace Editor for Vaadin Flow 14

Even more embeddable code editor custom Vaadin widget - Ace - The High Performance Code Editor

Originally based on LostInBrittany's fork of PolymerLabs ace-element

Created by Sergio Alberto Hilerio
Maintained by David "F0rce" Dodlek

Install

Install the component using Vaadin Directory:

<dependency>
   <groupId>com.hilerio</groupId>
   <artifactId>ace-widget</artifactId>
   <version>1.0.2</version>
</dependency>

<repository>
   <id>vaadin-addons</id>
   <url>https://maven.vaadin.com/vaadin-addons</url>
</repository>

Latest Version: v1.0.2

Documentation

docs.f0rce.de/ace

License

MIT License

aceeditorv14's People

Contributors

Stargazers

Watchers

Forkers

techtinkerer42 pflorek desertfox94 ericfranke ianyulianto

aceeditorv14's Issues

First click into editor doesn't allow to write

Hello,
in last version of this component we are facing an issue with focus/edit in this editor.

First click seem to only focus on the component but if you write something nothing happens (not even paste from clipboard).
After second click into editor it works correctly.

It looks like the first click only focuses the component but not enters the "edit mode"...

The next step 🥇

Dear @Sergio70,

it was a great pleasure working with you. I really want to thank you, for trusting me and letting me contribute as much as I wanted / needed to.

With Polymer 3 / Polymer-Element going end of life pretty soon and Vaadin's full support of Lit-Element (the newest and faster Webcomponent framework) I created a whole new version of the ace editor. With more functions, better lifecyle and so on.

I already told the people, that had problems with the current version ( #58 #56 ), to switch to the newer version to fix their issues, which was a great success.

So from now on, I will be focussing / maintaing the newer / current version of the ace editor:
https://github.com/f0rce/ace <-- Vaadin Add-on source code
https://github.com/f0rce/lit-ace <-- Frontend source code
https://vaadin.com/directory/component/ace <-- Vaadin Directory
https://www.npmjs.com/package/@f0rce/lit-ace <-- Frontend NPM package
https://docs.f0rce.de/ace <-- Documentation

I hope you are doing well in those difficult times and I hope that we will keep in touch.

Have a great day,
David Dodlek

Theme is not changing after setting different one via setter

I think that AceEditor.class -> public void setTheme(AceTheme theme) is missing:
this.editorTheme = theme;

Scrollbar flickering when scrolling

See attached Screen recording. When I try to scroll in the editor using the mouse wheel, the vertical scrollbar flickers in and out. Scrolling by dragging the bar is completely impossible.

The Issue seems to be that the default value for the maxLines is set to an Object containing Infinity

AceEditorV14/src/main/resources/META-INF/resources/frontend/@f0rce/ace-widget/ace-widget.js

Line 126 in 5a66129

value: { Infinity },

instead of a number. This does not work correctly with the underlying ace editor, since a Number or Falsy value is expected, not an Object.

As a workaround I set the maxLines to 0 manually in our Java-Code (aceEditor.setMaxlines(0);), but I think this should be fixed in general. Im not sure though what the best default value would be here. 0 works for our usecase, but maybe Infinity (without being packed in an object) would also work.

Quality of Life #1

Hello @Sergio70 ,

this issue is just here to inform you, that in today (or in the next few days) I will be uploading a new version of the ace-editor. The last few days I was playing quite a bit with the ace-editor and found some small "issues" regarding visibility and flow. There was also a small mistake in the synchronisation of the current selection which was also fixed.

I think some people will appreciate these changes :)

Stay safe,
David

[FeatureRequest] more setters like printMargin, showInvisibles etc.

Hi there,

first of all: thank you for this component, really appreciate the time!

Following setters would be nice:
setShowPrintMargin(boolean value);
setShowInvisibles(boolean value);
setShowGutter(boolean value);
setHighlightActiveLine(boolean value);

BlurEvent will probably cause jumping cursor (again)

The BlurEvent listens to the the 'editor-content' Event:

AceEditorV14/src/main/java/com/hilerio/ace/BlurChanged.java

Line 11 in ff76efb

@DomEvent("editor-content")

This causes a call from the frontend to the backend every time the content changed (Not on Blur).

Further more a Listener is added to this event which updates the content.

AceEditorV14/src/main/java/com/hilerio/ace/AceEditor.java

Line 30 in ff76efb

addListener(BlurChanged.class, this::updateText);

Updating the content of the backend content will also cause an update in the frontend. We creating kind of a loop! Exactly this mechanism was causing the original issue #7.
@F0rce have you tested your solution with setting the Network speed to 'slow 3G' or typed really fast?

[Update] v1.0.0

Hello everyone,

the last 3 weeks, I worked really hard on this widget and I'm really proud to say that version v1.0.0 is finally stable and ready to release.

I would like to thank @Sergio70 for trusting me and letting me contribute as much as I did and I really hope to continue my contribution in the future.

I'm going to write a full documentation by the end of the week.

Yours sincerely,
David

Found issues or want more features ?

Post them here.

I will take a look at it as fast as possible, because I returned from my school and holiday break.

~ David

Cursor jumps to the end of text

When I type quickly to the editor the cursor jumps at the end of text. It doesn't happen when I write slowly.
It hapens in version 1.4 Beta