Code Monkey home page Code Monkey logo

Comments (2)

iafan avatar iafan commented on July 26, 2024

When introducing this, my reason here was that we want to make sure what parts of the CSS belong to components (and only use this style for the root component class). This way it's easy to see that all rules that start with .BrowserTable relate to BrowserTable React component. As compared to that, .browser-table is less descriptive and can clash wit other ad-hoc styles that we already have accumulated. This naming would also allow us to cleanly migrate all the styles that belong to the components under their unique namespaces as we move parts of the UI into React, and at any time to see what global 'unclaimed' CSS styles we still have.

If you feel this approach is not worth the benefits, or if you have a better solution to dealing with CSS legacy, please speak up. Probably moving to another way of dealing with CSS will render such class names irrelevant.

Renaming these style names to foo-bar-baz ones is pretty straightforward, but I just wanted to emphasize that it was a deliberate decision that I believe would help us unwind the current CSS files.

from zing.

julen avatar julen commented on July 26, 2024

Probably moving to another way of dealing with CSS will render such class names irrelevant.

Exactly, and since we already have #9 on file and we are willing to have it addressed sooner than later, I really don't see the need to introduce and mix new naming conventions, especially seeing that these styles are already living in separate component-specific CSS files.

Moving declarations to separate files should be a good enough starting point to unwind the current monolithic CSS rules; the rest will depend upon the solution we decide on for components' styling.

from zing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.