Comments (2)
When introducing this, my reason here was that we want to make sure what parts of the CSS belong to components (and only use this style for the root component class). This way it's easy to see that all rules that start with .BrowserTable
relate to BrowserTable
React component. As compared to that, .browser-table
is less descriptive and can clash wit other ad-hoc styles that we already have accumulated. This naming would also allow us to cleanly migrate all the styles that belong to the components under their unique namespaces as we move parts of the UI into React, and at any time to see what global 'unclaimed' CSS styles we still have.
If you feel this approach is not worth the benefits, or if you have a better solution to dealing with CSS legacy, please speak up. Probably moving to another way of dealing with CSS will render such class names irrelevant.
Renaming these style names to foo-bar-baz
ones is pretty straightforward, but I just wanted to emphasize that it was a deliberate decision that I believe would help us unwind the current CSS files.
from zing.
Probably moving to another way of dealing with CSS will render such class names irrelevant.
Exactly, and since we already have #9 on file and we are willing to have it addressed sooner than later, I really don't see the need to introduce and mix new naming conventions, especially seeing that these styles are already living in separate component-specific CSS files.
Moving declarations to separate files should be a good enough starting point to unwind the current monolithic CSS rules; the rest will depend upon the solution we decide on for components' styling.
from zing.
Related Issues (20)
- In admin mode, filter out disabled projects from counters / translation views
- Avoid zero carry-overs
- Quality checks page requires help/_ttk_quality_checks.html
- Use Prettier for formatting frontend code
- Use Prettier for CSS formatting
- Upgrade Webpack
- Upgrade to latest React
- Make emojis work as placeables HOT 3
- Placeables should be inactive in read-only editor
- Editing a project fails source language validation
- Handle the case of an empty rendered string in Plurr preview HOT 5
- Support Plurr preview for simple {FOO}-style placeholders HOT 7
- Plurr preview pane to support empty parameters
- Visually identify LS Unicode symbol (U+2028) in the editor
- No module named 'syspath_override' HOT 2
- Incorrect number with the word count tracker HOT 3
- Issue building with python 3.7 HOT 4
- UI hangs indefinitely when attempt to translate a .po file with <= 10 entries HOT 5
- Exception in manage.py build_assets: 'gyp==0.1' distribution was not found
- UI hangs with spinner "Uncaught TypeError: this.unit is undefined" HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zing.