Code Monkey home page Code Monkey logo

Comments (2)

dtolnay avatar dtolnay commented on June 25, 2024

The current approach was put in place before serde_json had a build.rs. But now we have a build.rs anyway for a different reason, that might be a better place to do this check, if it can produce a good enough error.

With #1124:

error: serde_json requires that either `std` (default) or `alloc` feature is enabled
   --> serde-json/src/lib.rs:367:1
    |
367 | / compile_error! {
368 | |     "serde_json requires that either `std` (default) or `alloc` feature is enabled"
369 | | }
    | |_^

error: could not compile `serde_json` (lib) due to 1 previous error

Instead with this code in build.rs:

if cfg!(not(any(feature = "std", feature = "alloc"))) {
    eprintln!("serde_json requires that either `std` (default) or `alloc` feature is enabled");
    process::exit(1);
}
error: failed to run custom build command for `serde_json v1.0.115`

Caused by:
  process didn't exit successfully: `target/debug/build/serde_json-9e37cf325e9030a2/build-script-build` (exit status: 1)
  --- stderr
  serde_json requires that either `std` (default) or `alloc` feature is enabled

from json.

dtolnay avatar dtolnay commented on June 25, 2024

Some old workarounds that we could drop if build.rs does the check, meaning the library code would never even begin to build with an invalid combination of features: #643.

from json.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.