Breakage with recent nightly about aster HOT 9 CLOSED

Syntex v0.34 just came out, which I think contains MacroLoader. I'll see if I can get it working tonight if #83 doesn't do it.

from aster.

@alexbool: yep! We just released a new serde_codegen and serde_macros.

from aster.

I had a quick look at this, and it looks like it's due to rust-lang/rust@51499b6

@erickt @dtolnay Is there going to be extra work needed in syntex to expose something like the newly public MacroLoader in rustc_metadata, and will that affect what the ExtCtxt does?

from aster.

I gave it a go using the DummyMacroLoader but I closed my pull request because I'm not sure it is what is needed. Maybe someone more experienced with these crates can have a look? #83

from aster.

Keen to see the implementation, I'm not familiar with MacroLoader so don't know what it does

from aster.

Doesn't look like Syntex 0.34 contains MacroLoader - the libsyntax in 0.34 is from 2016-06-07 while MacroLoader merged on 2016-06-09.

from aster.

Thanks!
I guess now you also have to push a new serde release?

from aster.

Thank you very much!

from aster.

@nubis @KodrAus in case you are still curious, here is the fix that Erick ended up making: syntex/src/lib.rs

from aster.