Windows Phone 8 false detection about mobile-detect HOT 9 CLOSED

@Mddw thanks man! Will commit this asap!

from mobile-detect.

Is it not possible to check with the below expression?

'WindowsPhoneOS'   => 'Windows Phone|XBLWP7|ZuneWP7' 

It would be simpler, faster and compatible with future versions, contrary to the above suggestion.

from mobile-detect.

It's my understanding that Windows Mobile 6.5 has Windows Phone in its UA and is not a Windows Phone.
Moreover, you can't realy presume future versions UA.

from mobile-detect.

@stevendegroote @Mddw yes I can use a simple regex, but I prefer to keep it segmented because it's easier for me to spot a future conflict and it also keeps me informed to make a future differentiation between Windows Mobile and Windows Phone.

from mobile-detect.

Fair enough, I can live with that. I just wanted to point some additional attention to trying to ensure as much future compatibility as possible to reduce workload for you as well as for the people using this library.
Keep up the good work!

from mobile-detect.

A little different issue, but always on the same phone, so I post it here.

On the same phone/OS (Nokia Lumia 620/WP8), there is a desktop mode you can set in settings. It changes the UA to :

Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.2; Trident/6.0; ARM; Touch; WPDesktop)

With this setting and according to demo.mobiledetect.net, only isMobile is True, everything else is falsy.

I don't know what's the expected behavior of mobile-detect when a phone is in desktop mode, but I think it should not trigger isMobile().

BTW I did not check in the code what's causing this, but if you need some testing just ask, I'll be happy to help.

edit : i came on this issue directly, so did not see the same issue 58 : #58

from mobile-detect.

@Mddw - I have to think about this. I could look for WPDesktop but since the script's main purpose is to detect the mobile devices no matter what it might impact other users. I have to gather some feedback. Thanks for revealing this!

from mobile-detect.

I think you should do both : leave the choice to the developer.
Maybe a wantDesktop() completing isMobile() ?
Not a priority maybe, but please consider it.

from mobile-detect.

Done, check https://github.com/serbanghita/Mobile-Detect/archive/2.5.8.zip

Also, @Mddw isDesktopMode should be a good starting point.

from mobile-detect.