Code Monkey home page Code Monkey logo

Comments (10)

sentenza avatar sentenza commented on August 19, 2024 2

I respectfully disagree here. If this was a library, I would agree 100%. This seems to be rather a showcase (and a very good one!) of Scala () implementation of algorithms and data structure.

This to me is a clear case where it can be even useful a separation between Scala 2 and Scala 3.

Having said that, of course one can do a mix, but I'd rather not :D

Please keep in mind that this is an educational project. The code presented here should be used to learn how to implement common algorithms in Scala. There is no dependency with anything else but the standard library for this specific reason.

It's easy to define a common strategy here. The perfect analogy is the way EPFL and Coursera are managing the revamped Scala courses: they're just updating their content to target Scala 3. The same goes with the books and all the official manuals.

Scala 2 is now the past.

No backsies. 🙅‍♂️

from scala-algorithms.

mfirry avatar mfirry commented on August 19, 2024

Few notes here:

  • in MutableSorting Do-While syntax needs to be dropped (see here)
  • in Tree there are some minor errors for generic runtime erasure

Can't see anything else.

from scala-algorithms.

mfirry avatar mfirry commented on August 19, 2024

Unless we want to move to optional braces as well.

from scala-algorithms.

mfirry avatar mfirry commented on August 19, 2024

Ah no sorry. Of course all ADTs can be rewritten using enums now. Should we do that as well?

from scala-algorithms.

sentenza avatar sentenza commented on August 19, 2024
  • in MutableSorting Do-While syntax needs to be dropped (see here)

@mfirry yes, drop it! ;)

  • in Tree there are some minor errors for generic runtime erasure

Use enum for ADTs 👌

I assigned this one to you. Happy coding! 🎈

from scala-algorithms.

mfirry avatar mfirry commented on August 19, 2024

Loudly thinking: I think enums for ADT will basically mean breaking out from Scala 2. Not sure you want that.
How about creating a new repo? hacktoberfest-scala3-algorithms?

from scala-algorithms.

sentenza avatar sentenza commented on August 19, 2024

Loudly thinking: I think enums for ADT will basically mean breaking out from Scala 2. Not sure you want that. How about creating a new repo? hacktoberfest-scala3-algorithms?

I'd rather prefer to have a single repo and a main branch. Maybe we could start creating a first Scala 3 version while tagging the previous one as scala-2.

I don't want to fall into the same errors that the Python community did in the near past when switching to a new major version of the language.

from scala-algorithms.

mfirry avatar mfirry commented on August 19, 2024

I respectfully disagree here. If this was a library, I would agree 100%.
This seems to be rather a showcase (and a very good one!) of Scala () implementation of algorithms and data structure.

This to me is a clear case where it can be even useful a separation between Scala 2 and Scala 3.

Having said that, of course one can do a mix, but I'd rather not :D

from scala-algorithms.

ivanopagano avatar ivanopagano commented on August 19, 2024

submodules?

from scala-algorithms.

mfirry avatar mfirry commented on August 19, 2024

submodules?

It's definitely an idea.

from scala-algorithms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.