Code Monkey home page Code Monkey logo

Comments (4)

Deewii avatar Deewii commented on September 4, 2024

Easily fixed, seems to be a small "typo" in the code. static/js/map.js

function isNotifyPerfectionPoke(poke) {

    var hasHighIV = false
    var hasHighLevel = false
    var hasHighAttributes = false

    if (poke['individual_attack'] != null && poke['cp_multiplier'] !== null) {
        const perfection = getIv(poke['individual_attack'], poke['individual_defense'], poke['individual_stamina'])
        const level = getPokemonLevel(poke['cp_multiplier'])

        hasHighIV = notifiedMinPerfection > 0 && perfection >= notifiedMinPerfection
        hasHighLevel = notifiedMinLevel > 0 && level >= notifiedMinLevel

        hasHighAttributes = (hasHighIV && !(notifiedMinLevel > 0)) || (hasHighLevel && !(notifiedMinPerfection > 0)) || hasHighLevel && hasHighIV
    }

    return hasHighIV
}

Should return return hasHighAttributes

from rocketmap.

darkelement1987 avatar darkelement1987 commented on September 4, 2024

Is that code already fixed or do i still need to replace something there? Also why does it need fixing @ function for perfection if the problem is in the levels? Sorry im not a coder myself

edit: Works! THANKS!

from rocketmap.

darkelement1987 avatar darkelement1987 commented on September 4, 2024

Question, stock rm uses return isOnNotifyList || hasHighIV why is this different?

from rocketmap.

rlodev67 avatar rlodev67 commented on September 4, 2024

@darkelement1987 Cause Pokemon on notify list shouldn't be hide

from rocketmap.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.