[BUG] about vba-better-array HOT 7 CLOSED

Should do. That's actually part of the reason this bug occurred. These headers sometimes have varying numbers of spaces:

"Field with 
multiple lines" ,"Another field 
with some 
line breaks inside" , "Include some  comma, for test, and some [""] Quotes" , "Normal field here" 

That whole sample file parses without issue now.

Also worth noting that all strings parsed from the CSV are trimmed in this function, so that " some field here " is stored as some field here:

Private Function UnquoteString(ByRef element As String) As String
    Dim localElement As String
    localElement = Trim$(element)
    If Asc(Left$(localElement, 1)) = 34 And Asc(Right$(localElement, 1)) = 34 Then
        'trim string delimiters
        localElement = Mid$(localElement, 2, Len(localElement) - 2)
    End If
    UnquoteString = Trim$(localElement)
End Function

from vba-better-array.

Just tested this as a CSV:

"Field with 
multiple lines" ,"Another field 
with some 
line breaks inside   "    , "Include some  comma, for test, and some [""] Quotes" , "Normal field here" 
1, 2,    3    ,4 
            Field 1,            Field 2                ,               Field 3 , Field 4

and I get this as the output:

So yes is the answer

from vba-better-array.

Thanks for your answer! I have successfully updated benchmark on a local branch. In the next few days I'll put in online and alert to you. So, delayed by an unexpected errors fixes, I hope the code be available to the community very soon. 😎

from vba-better-array.

Hey! Thank you so much for letting me know about this!

It was a simple off-by-one error as far as I can tell - the above commit solves the issue by changing:

                    j = j + 1
                    cursor = j + 1

To:
cursor = j + 2

from vba-better-array.

I'd be very grateful if you could retest on your end if you find the time (release 1.6.1). Of course, if there are still problems I will happily reopen this issue.

from vba-better-array.

I also just fixed an issue where string in CSV weren't getting unquoted correctly in v1.6.2 just now, so that's the latest release

from vba-better-array.

Only a question, before do anything, can your parser handle an variable number of trailing spaces? i.e. A secuence like Space(2) & "," & Space(1) or Space(4) & "," and en of a record.

from vba-better-array.