Stack overflow caused by @extends about jsduck HOT 6 CLOSED

This has been up for so long and nobody is really complaining about this. So closing this down for now.

from jsduck.

Just reproduced it with 4.4.1 windows binary, pattern is the same (spent a lot of time trying to find where the self-extension is).

lib/jsduck/relations.rb:40: stack level too deep (SystemStackError)

from jsduck.

Hmm.. actually I implemented a fix for this in 4.3.2.

But apparently it's not catching all the cases.

Care to provide a code example?

from jsduck.

/**
 * @class
 * @extends B
 */
A = {};

/**
 * @class
 * @extends A
 */
B = {};

Error: Class A has a circular dependency: A extends B extends A

Any properties/methods cause the overflow:

/**
 * @class
 * @extends B
 */
A = {};

/**
 * @class
 * @extends A
 */
B = {c: 'd'};

lib/jsduck/relations.rb:40: stack level too deep (SystemStackError)

from jsduck.

Thanks.

from jsduck.

The problem wasn't just the existence of members, but auto-detected members without documentation - for these JSDuck tried to inherit documentation from parent and ended up in infinite loop.

I was doing the circular dependencies check too late - I've now moved it before the documentation inheritance processing.

Fixed in 0dc7335

from jsduck.