AR Mass Edit about senaite.core HOT 15 CLOSED

Edit, language and details

All of this can be easily achieved, and in very rich functionality, by merging @rockfruit's splendid UW code, and also do away with Bulk AR Import by using the UW Batch AR Create code, specifying shared attributes only once. It was functional and trimmed down for merging with Bika LIMS 3.4 already. Only a few retirements and handovers in the lab stalled this process

Thanks for putting me onto this one @grulisco

from senaite.core.

@rockfruit: Can you please technically explain what you have done in the UW branch?

The following requirements are behind this feature:

• Based on AR Add 2 to avoid code duplication
• Capability to add/remove Profiles
• Allow fields to be edited depending on the WF state of the AR

Until now this was only a PoC (see PR), so it would be great to have this ready to use in code.
A related issue in the old tracker was this one: bikalims/bika.lims#2192

from senaite.core.

Is their progress on this. If we can form a reasonable time and effort estimate, i'll pump for sponsorship of the Create part to start off with. Please post your estimates (and pointers to the code) @rockfruit, @ramonski.

We are migrating AR Import for Cannabis and once we have that in place as a fall back, could turn to Batch AR create if it is not too big a job. Shouldn't be, it worked for UW

from senaite.core.

This issue will become important for us, so we would join in sponsoring this one...

from senaite.core.

I'm still waiting on an answer on this @lemoene. If I understood you right, this feature is already done in the UW branch? If so, please add a PR for review. Thanks

from senaite.core.

K. Time and effort @mikejmets ?

from senaite.core.

I did not dig far enough for the UW comms to retrieve a spec, but it was functional and trimmed down from elaborate UW spec for merging with Bika LIMS 3.4 already if I iunderstood @rockfruit correctly. Before that, a review ran beautifully

see if I can find a spec...

from senaite.core.

Found an old running instance, not the latest, where this and also Batch and WS integrations, reach useful status, https://jira.bikalabs.com/browse/LIMS-2750

It completes quite a bit already, though clumsily, I thought we had better UI, maybe in the final versions

Edit, re below image The AR Create form below was populated from values captured at Batch level (in this version), without really having to navigate to the AR Create form at all. This could replace the Bulk AR Import by spreadsheet, on big batches of 100+ common in some labs.

In the improved version, none of which I analyst can find easily, will post a link when I do, the Sample/AR specific attributes are captured in a simplified table, e.g CSID, etc. Then after Create, singular ARs can be edited.

A similar screen is/was to be provided for bulk edits of ARs in a batch; and NB, the Bulk AR spreadsheet inport improved to 'bulk edit' ARs by overwriting them from the import

from senaite.core.

@lemoene: You were talking that you have "beautiful code for this, and it is beyond you why it gets ignored". The link you posted above shows just numerous screenshots, but I can find neither a specification nor the "splendid UW code" you mentioned.

The screenshot above shows the AR Add form as the label already suggests. So I don't understand that neither.

Please provide that code either as a link or in a PR (preferred), and please only use the tracker for technical related contributions and use other communication channels for time/effort/sponsorship discussions – Thanks for understanding.

from senaite.core.

As you wish, you leave the project vulnerable to duplication by not allowing discussions like this. It happened already. There are not nearly enough LIMS experience in Riding Bytes to discourage rich user and business analyst discussions in a tracker of some sorts. It already cost us dearly when you announced Senaite production-ready and in truth it was only for a singular use case.

IMO you should be using all the user and analyst feedback on offer and exploit it. Maybe you saw the Beekeeper model. You should also state clearly that this forum is for coders only, I won't do it until a suitable replacement is set up. Frustrating that you simply cannot let it be and for self regulation to rule.

I have been talking about this really valuable cache of UW code for months, am not tech and referred you to proud author Campbell and stepped on it again when you met in Barcelona. It was widely ignored. This is not the platform for that discussion, but he got badly undermined in his attitude towards me, what little grip I had on his wayward genius evaporated and we are reaping the consequences now.

Wrt to this issue, I clearly laid out that I don't have my hands on the code and the screenshots were used by way of illustration of what was achieved already. The obvious place to do that was on this issue here before things gets duplicated. That is also the only spec I have it seems, apart from initial older ones - I came to the conclusion that it was finalised in many granular improvements requests in the Bika tracker. I can write it up, but then there is nowhere to stick it up.

Also not for here, but the Senaite space is clearly not shaped optimally or entirely free and already some of our work that should be promoting Senaite gets painted in at Bikalims.org. Decision time is fast approaching whether maybe to continue under that banner where we can operate in an uninhibited environment. Bika Cannabis, because of the hype around it, and the alliteration in the name!-) will be marketed as such.

from senaite.core.

re The AR Create form image

It was populated from values captured at Batch level as showed off with screenshots of other desirables in the UW code at https://jira.bikalabs.com/browse/LIMS-2750 (in this older running version), without really having to navigate to the AR Create form at all.

This could replace the Bulk AR Import by spreadsheet, very cool for big batches of 100+ common in some labs.

In the improved version - none of which code I analyst can find easily, will post a link when I do - the Sample/AR specific attributes are captured once in a simplified tab, e.g CSID, etc. Then after Create, singular ARs can be edited.

A similar screen is/was to be provided for bulk edits of ARs in a batch; and NB, the Bulk AR spreadsheet import improved to 'bulk edit' ARs by overwriting them from the new import

Batch and Worksheet integration is the other much desirable feature that deserves being rescued, different issue, logged at the bottom of https://jira.bikalabs.com/browse/LIMS-2750 too.

from senaite.core.

UW code always lived in its own fork, as well as baobab, cannabis and others. Obviously, one cannot expect Senaite to include functionalities that were disseminated amongst a myriad of custom-made forks that were meant to be used for specific clients only. Claiming here that we missed (and/or we don't want) to merge that "splendid" code that no one knows where it currently lives is non-sense.

If you are able to find that code and think is worth, open a Pull Request, but please @lemoene , don't add more confusion with functionalities that never reached the public repos.

from senaite.core.

To clear the confusion I'll continue with tracking feature requests in Jira, there is great value to the information collected there already, will clean it up. That could help preventing duplication somewhat.

The UW project was very public, I only took their tracker items private recently when they were considering a restart. Maybe the code ended up in Campbell's not easy to find. LIMS analysts and users hardly go there.

The functionality was Bika LIMS 3.4 ready, communicated again before the Barcelona meet-up. The migration ship was sailing just then. Indeed I came to now realise it is an opportunity missed, great functionality, and stable. No feedback was given by anybody, 'not wanting to' I did not say, just thought 'too busy'.

The functions are now probably better rewritten. I was holding out for maybe more affordable refactoring, having at a minimum a proto-type and some code to work from.

from senaite.core.

I must chime in here (better late than never). I've just now written and deleted an essay on this discussion!; however this comment will instead focus on the subject of this issue, AR Mass Edit, which is functionality that has never existed in Bika LIMS before.

I agree that the quickest, simplest, and most robust solution is to use the add2 form. It's perfect.

The only place this breaks down a bit is when a user wants to change one field value inside some hundreds of ARs simultaneously. There was a function to switch layout of the AR-Add form from columns to rows; combined with the ability to modify which fields are displayed in the form, this may allow the add2 form to mass-edit very many ARs.

Side note regarding "arimport": if the add2 form supports switching layout, it may well be used as an intermediate stage for importing ARs from an externally created file; however I feel that's a cop-out. If our UI is so bad that a user must resort to an XLS file, then our job is to create a better UI. The row-layout add2 form could be sufficient.

All of this is for the case of creating/editing Analysis Requests; these objects are a special case, as they create/influence samples, analyses, etc during their creation/editing. I think we should probably intend to create a more general mass-edit form, for changing a single field value of a selected group of any type of object.

from senaite.core.

Won't be implemented.

from senaite.core.