Comments (2)
The reason why the YAML fails to parse is because the shell command on line 24 has nine instances where the closing square bracket is escaped but their corresponding opening square brackets are not escaped.
If this inconsistency is fixed then the file parses as expected:
RUN echo "PS1="[\e[91m]\u[\e[0m][\e[2m]@[\e[0m][\e[94m]\h[\e[0m]:[\e[32m]\w[\e[0m] [\e[2m]=>[\e[0m] ""
from semgrep.
@jkinsfather's code above fixes the code for the Bash prompt (which originally showed spurious closing brackets) and it also serves as a workaround for semgrep's parsing bug.
I'm reopening the issue because there's still a bug in Semgrep's Dockerfile parser. The following Dockerfile
is accepted by docker
but not by semgrep
:
FROM ubuntu
# sh command to set text color to red (does nothing useful but is valid)
RUN echo "\e[91m"
Edit: the command echo "\e[91m"
sets the text in red in sh
(the default shell used by Docker to process the RUN instructions) but not in bash
, although it's syntactically valid in both cases.
docker
is happy:
$ docker build -t test .
[+] Building 0.0s (6/6) FINISHED
=> [internal] load build definition from Dockerfile 0.0s
=> => transferring dockerfile: 112B 0.0s
=> [internal] load .dockerignore 0.0s
=> => transferring context: 2B 0.0s
=> [internal] load metadata for docker.io/library/ubuntu:latest 0.0s
=> [1/2] FROM docker.io/library/ubuntu 0.0s
=> CACHED [2/2] RUN echo "\e[91m" 0.0s
=> exporting to image 0.0s
=> => exporting layers 0.0s
=> => writing image sha256:c0f4394029c2ee3b806186b37a86ccf79c5bf6057f85d 0.0s
=> => naming to docker.io/library/test 0.0s
But semgrep
fails to parse the RUN line:
$ semgrep -l docker -e 'RUN ...' Dockerfile --verbose
No .semgrepignore found. Using default .semgrepignore rules. See the docs for the list of default ignores: https://semgrep.dev/docs/cli-usage/#ignoring-files
Rules:
- -
[WARN] Syntax error at line Dockerfile:4:
`RUN echo "\e[91m"` was unexpected
...
from semgrep.
Related Issues (20)
- Reusable patterns
- False Positives in Taint Mode when multiple related sanitizer rules defined with focus-metavariable HOT 4
- Ability to Specify Code Assumptions HOT 1
- Elixir mix lockfiles fail to parse certain git definitions HOT 3
- Failed to find semgrep-core in PATH or in the semgrep package. HOT 2
- `metavariable-pattern` with `pattern-regex` doesn't match `_`
- Cheatsheet broken for several GA languages
- "new" keyword in C# throws error HOT 1
- named match group in metavariable-regex causes duplication of matches
- metavariable-pattern always fails with aliengrep
- `match` matching ignores the branches enum variant names
- osemgrep: no files scanned when they should be
- Pattern parser throws an error when parsing patterns with explicit private attributes
- Ruby scanning not working in JS version of Semgrep VSCode Extension HOT 1
- Syntax when parsing kotlin code
- High Semgrep LSP CPU usage caused by recurring Git operations
- Whether the current feature supports taint analysis to detect memory leakage
- `--output` seems ignored when running `--test`
- "taint_assume_safe_functions: true" dosen't work while setting "control: true" in pattern-sources filed
- Support for non-file configuration (and tests, maybe)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from semgrep.