Code Monkey home page Code Monkey logo

Comments (2)

jkinsfather avatar jkinsfather commented on May 24, 2024 1

The reason why the YAML fails to parse is because the shell command on line 24 has nine instances where the closing square bracket is escaped but their corresponding opening square brackets are not escaped.

If this inconsistency is fixed then the file parses as expected:
RUN echo "PS1="[\e[91m]\u[\e[0m][\e[2m]@[\e[0m][\e[94m]\h[\e[0m]:[\e[32m]\w[\e[0m] [\e[2m]=>[\e[0m] ""

from semgrep.

mjambon avatar mjambon commented on May 24, 2024

@jkinsfather's code above fixes the code for the Bash prompt (which originally showed spurious closing brackets) and it also serves as a workaround for semgrep's parsing bug.

I'm reopening the issue because there's still a bug in Semgrep's Dockerfile parser. The following Dockerfile is accepted by docker but not by semgrep:

FROM ubuntu

# sh command to set text color to red (does nothing useful but is valid)
RUN echo "\e[91m"

Edit: the command echo "\e[91m" sets the text in red in sh (the default shell used by Docker to process the RUN instructions) but not in bash, although it's syntactically valid in both cases.

docker is happy:

$ docker build -t test .
[+] Building 0.0s (6/6) FINISHED                                                
 => [internal] load build definition from Dockerfile                       0.0s
 => => transferring dockerfile: 112B                                       0.0s
 => [internal] load .dockerignore                                          0.0s
 => => transferring context: 2B                                            0.0s
 => [internal] load metadata for docker.io/library/ubuntu:latest           0.0s
 => [1/2] FROM docker.io/library/ubuntu                                    0.0s
 => CACHED [2/2] RUN echo "\e[91m"                                         0.0s
 => exporting to image                                                     0.0s
 => => exporting layers                                                    0.0s
 => => writing image sha256:c0f4394029c2ee3b806186b37a86ccf79c5bf6057f85d  0.0s
 => => naming to docker.io/library/test                                    0.0s

But semgrep fails to parse the RUN line:

$ semgrep -l docker -e 'RUN ...' Dockerfile --verbose
No .semgrepignore found. Using default .semgrepignore rules. See the docs for the list of default ignores: https://semgrep.dev/docs/cli-usage/#ignoring-files
Rules:
- -
[WARN] Syntax error at line Dockerfile:4:
 `RUN echo "\e[91m"` was unexpected

...

from semgrep.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.