Code Monkey home page Code Monkey logo

Comments (10)

PeterTheOne avatar PeterTheOne commented on August 17, 2024

But does clicking cancel work?

$( '<span>', {
'id' : 'collabComEditFormCancel',
'text' : ' | ' + ceLanguage.getMessage( 'ce_cancel_button' ),
'click' : function() {
ceCommentForm.cancelCommentEditForm( pageName );
}
}).appendTo( buttonBox )

from semanticcomments.

krabina avatar krabina commented on August 17, 2024

no. It does not have to be a button, but the result currently is onyl the text that is not clickable

from semanticcomments.

PeterTheOne avatar PeterTheOne commented on August 17, 2024

Any javascript errors in the browser console?

from semanticcomments.

krabina avatar krabina commented on August 17, 2024

No errors. This is the resulting HTML:
grafik

from semanticcomments.

PeterTheOne avatar PeterTheOne commented on August 17, 2024

Works for me in chromium:

sc-cancel

from semanticcomments.

PeterTheOne avatar PeterTheOne commented on August 17, 2024

@krabina What happens when you enter ceCommentForm.formReset(); into the console, with the add comment open?
Also which browser are you using?

from semanticcomments.

krabina avatar krabina commented on August 17, 2024

Pulled the latest master version (just to make sure), used Crome Version 65.0.3325.181 - same thing. When I enter the ceCommentForm.formReset(); than it closes the edit window as expected.

The problem is that the "Cancel" is not blue but grey and therefore is no link...

from semanticcomments.

krabina avatar krabina commented on August 17, 2024

In the HTML above, the "Abbrechen" should be inside the span tag. Wen I do that manually it works.

Mut be here somehwere:

$( '<span>', {
'id' : 'collabComEditFormCancel',
'text' : ' | ' + ceLanguage.getMessage( 'ce_cancel_button' ),
'click' : function() {
ceCommentForm.cancelCommentEditForm( pageName );
}
}).appendTo( buttonBox )

from semanticcomments.

PeterTheOne avatar PeterTheOne commented on August 17, 2024

You are right, | Abbrechen should be in the span. CE_Coment.js looks fine.

Is the html of the site otherwise valid ( https://validator.w3.org/ )?

from semanticcomments.

kghbln avatar kghbln commented on August 17, 2024

This extension was abandoned. See #25 for further details and an alternative.

from semanticcomments.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.