[🐛 Bug]: ValueError: ZIP does not support timestamps before 1980 about selenium HOT 7 OPEN

@titusfortner I added a private field to the class with a default value of True. The property can be set to False, as in the case for fixing the current bug. I believe such changes should not break client code that does not use setting a value to the field self._strict_timestamp.

from selenium.

thanks for the patch

can we change the default to self._strict_timestamp = False?
i guess no one will care about pre-1980 timestamps in a firefox profile zip ...

    @property
    def encoded(self) -> str:
        """Updates preferences and creates a zipped, base64 encoded string of
        profile directory."""
        if self._desired_preferences:
            self.update_preferences()
        fp = BytesIO()
        with zipfile.ZipFile(fp, "w", zipfile.ZIP_DEFLATED) as zipped:
            path_root = len(self.path) + 1  # account for trailing slash
            for base, _, files in os.walk(self.path):
                for fyle in files:
                    filename = os.path.join(base, fyle)
                    zipped.write(filename, filename[path_root:])
        return base64.b64encode(fp.getvalue()).decode("UTF-8")

from selenium.

@milahu, thank you for creating this issue. We will troubleshoot it as soon as we can.

from selenium.

I'm not sure the value of maintaining time stamps vs supporting profiles generated with timestamp zero.

Would you like to make a PR with the value configurable in the constructor or a property of the profile class?

from selenium.

This issue is looking for contributors.

Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested.

from selenium.

@milahu @titusfortner I changed the default value to False
I believe that the behavior in the client code will not change at all, because until the current changes, users could not directly pass the argument value or influence it in any way. This means that after the current pull request, this bug will be fixed - this is what we are aiming for. However, if they set the flag self_strict_timestamps = True, the bug will reoccur - this is the expected behavior.

from selenium.

added my comments to the PR

from selenium.