[🚀 Feature]: Convenience methods for BiDi about selenium HOT 10 CLOSED

I am not sure. If we want to set a property or a value, I like the setXYZ pattern, but if we want to enable a feature, I prefer the enableXYZ pattern.

This is to be said, I saw setEnableDownloads too late; it was already released. I would have done enableDownloads.

from selenium.

Thank you folks. I think I will go with enableBiDi.

from selenium.

@pujagani I'm guessing we don't have a good reason for not adding it to java, yet?

from selenium.

Thank you for bringing this up. Actually we can add it.

from selenium.

"options.enableBiDi(true)" - @titusfortner Should the user need to pass in true? Isn't enableBidi() sufficient?

from selenium.

@pujagani I thought the other methods in Java Options that are boolean require passing in true/false.
So, we should do whatever matches the rest of our code.

from selenium.

That is a fair point. Though the naming, in that case, is like setEnableDownloads(boolean enableDownloads). I was thinking if the name is enableBiDi, then that means just enable it. But if we want to set a value then the name should be such. What do you think?

from selenium.

If setXX(boolean) is the pattern, then we should follow that, though I agree it seems a bit much. @diemol any opinions on our conventions here?

from selenium.

Present in python a51ddee

from selenium.

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.

from selenium.