Code Monkey home page Code Monkey logo

Comments (11)

p0deje avatar p0deje commented on June 16, 2024 1

@amcmillion3 This is correct, the deprecation will go away in the newer version of Rails.

from selenium.

github-actions avatar github-actions commented on June 16, 2024

@shouichi, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

from selenium.

diemol avatar diemol commented on June 16, 2024

@titusfortner do you know if this is correct?

from selenium.

searls avatar searls commented on June 16, 2024

I am running into the same thing. Unless I pin to 4.19.0 I get Selenium::WebDriver::Error::UnknownError: unknown error: cannot find Chrome binary cc/ @p0deje

from selenium.

p0deje avatar p0deje commented on June 16, 2024

Ideally, Rails would not attempt to preload drivers/browsers via a direct API call of Selenium. Reading through the code, this is done to avoid race conditions when running tests in parallel. I think that Selenium should handle this internally so that concurrent attempts to preload the driver/browser would ensure there are no race conditions and wait for the first process to finish downloading, then yield to other binary calls. With this implementation in place, the related part of Rails code can be removed:

https://github.com/rails/rails/blob/dcfabdbe4e7e53fc757d0ebf89c77349899a35bb/actionpack/lib/action_dispatch/system_testing/browser.rb#L40-L49

It's a fairly simple change that I can do both in Selenium and Rails, but I am not sure if that suits the Rails users. @searls Do you happen to know if it would be fine for Rails to pin Selenium to say >= 4.20.2 in the next Rails version?

from selenium.

searls avatar searls commented on June 16, 2024

It's a fairly simple change that I can do both in Selenium and Rails, but I am not sure if that suits the Rails users. @searls Do you happen to know if it would be fine for Rails to pin Selenium to say >= 4.20.2 in the next Rails version?

I'm not on Rails core so it's not for me to say, but I would wager that simply releasing a fix in Selenium to allow anyone who runs into this to receive the fix via bundle update to a patch release would be plenty to resolve it, regardless

from selenium.

p0deje avatar p0deje commented on June 16, 2024

@searls @shouichi Can you see if 4.21.1 solve the problem for you?

from selenium.

shouichi avatar shouichi commented on June 16, 2024

@p0deje 4.21.1 solved the problem. Thank you!

from selenium.

diemol avatar diemol commented on June 16, 2024

Great!

from selenium.

searls avatar searls commented on June 16, 2024

Confirm: fixed me too

from selenium.

amcmillion3 avatar amcmillion3 commented on June 16, 2024

We're using selenium-webdriver 4.21.1 in our Rails application, but we're still seeing the deprecation message. Based on this discussion, it sounded like the deprecation warning going off is a byproduct of how Rails system tests work. Is it fair to assume that there's not direct action that we can take for the time being to resolve this issue?

from selenium.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.