Comments (5)
This is definitely a dependency, not a dev or peer one. I probably think it'd be easier to simply list the methods where they are necessary.
from jscs-config-seegno.
@ruiquelhas can you take of this? https://github.com/seegno/jscs-config-seegno/blame/master/src/rules/require-should-assertion-execution.js#L8 we can either cache this or mark this a dependency instead.
from jscs-config-seegno.
We have the same issue for jscs
, although that one is part of the installation instructions. They were peerDependencies
before, to avoid this kind of issues (or at least to provide proper installation warnings).
I'm not sure if it's a good idea to move them to the dependencies, so I would suggest to just add should
to the installation instructions.
from jscs-config-seegno.
I have a better solution for this I think - invoke the require
call inside a try catch and only add this rule if the should
package is installed. Since most dev envs will already have it, those who forget to install it or are simply not interested in loading it, will not suffer from it.
from jscs-config-seegno.
Not solved by #23. We still need to implement @ruimarinho suggestion.
from jscs-config-seegno.
Related Issues (14)
- Normalize YAML sequence format
- False positives for requireSqlTemplateInQueryFunction HOT 4
- Required new line before `typeof`
- Remove `jscs` dependency
- Add `disallowSpacesInsideTemplateStringPlaceholders` rule
- Add `requireSpaceBeforeDestructuredValues` rule
- Add `should.js` as a peer dependency HOT 1
- Uncaught Error: Config values to remove in 3.0: The `esnext` option is enabled by default. HOT 1
- Padding new lines after assignment blocks
- Remove validateOrderInObjectKeys rule
- Fix issue in padding newlines before keywords rule
- Support ES5 and ES6/ES2015 projects HOT 2
- Remove `requireCurlyBraces` Case statement without curly braces HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jscs-config-seegno.