Code Monkey home page Code Monkey logo

Comments (9)

jesskfullwood avatar jesskfullwood commented on May 13, 2024

There was some discussion of this in the original PR. It should obviously be done but it seems the implementation will need some thought.

from seed.

glademiller avatar glademiller commented on May 13, 2024

I totally agree. A solid solution wasn't super obvious or I would have opened a PR. Just for the sake of furthering the discussion my expectation was to be able to handle the error case and send a Msg just like I did for the success case.

from seed.

glademiller avatar glademiller commented on May 13, 2024

Looking at the discussion it seems to revolve primarily around how to handle the two different error types. For my particular use case a new error type that has From implemented for both would be enough. What other options would seem to fit the situation? If an ideal solution could be hashed out I might be able to spare some time to put up a pr.

from seed.

sapir avatar sapir commented on May 13, 2024

Futures are now returned from update, and their result needs to be Result<Msg, Msg>, so the error case is now passed as a Msg back to the update function.

from seed.

David-OConnor avatar David-OConnor commented on May 13, 2024

@glademiller does sapir's latest PRs/the 3.0 release resolve this?

from seed.

glademiller avatar glademiller commented on May 13, 2024

from seed.

MartinKavik avatar MartinKavik commented on May 13, 2024

I'll try to fix it.

from seed.

MartinKavik avatar MartinKavik commented on May 13, 2024

@glademiller Merged PR #118 should resolve your problems - could you provide feedback or/and close the issue?

from seed.

glademiller avatar glademiller commented on May 13, 2024

I haven't dug too deep but looking at the code I believe this solves the issues I had. Thank you!

from seed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.